<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 15 Jan 2024, 3:42 pm Thomas Larsen Wessel, <<a href="mailto:mrvelle@gmail.com">mrvelle@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>When you guys run these tests locally, do they all pass?</div><div><br></div>After some fiddling I have removed some errors, caused by incorrect build setup. But I still have 19 failing tests. <div><br></div><div>2 - checkGitStatus (Failed)<br>22 - ProcessingGrass7AlgorithmsRasterTestPt2 (Failed)<br>24 - ProcessingOtbAlgorithmsTest (Failed)<br>46 - test_core_compositionconverter (Failed)<br>108 - test_core_layoutpicture (Failed)<br>177 - test_core_settingsentry (Failed)<br>280 - test_gui_filedownloader (Subprocess aborted)<br>288 - test_gui_featurelistcombobox (Subprocess aborted)<br>298 - test_gui_queryresultwidget (Subprocess aborted)<br>302 - test_3d_3drendering (Failed)<br>309 - test_3d_mesh3drendering (Failed)<br>332 - test_provider_wcsprovider (Failed)<br>413 - PyQgsAnnotation (Failed)<br>489 - PyQgsExternalStorageWebDav (Failed)<br>490 - PyQgsExternalStorageAwsS3 (Failed)<br>600 - PyQgsMapCanvas (Failed)<br>601 - PyQgsMapCanvasAnnotationItem (Failed)<br>672 - PyQgsProcessExecutablePt1 (Failed)<br>673 - PyQgsProcessExecutablePt2 (Failed)<br></div><div><div><br></div><div>I think I understand checkGitStatus and can safely ignore that one. But what about the rest? Is it "normal" that so many tests fail when running tests locally?</div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">That's more than I'd expect to fail on 22.04 -- at least, the main qgis ci workflow uses 22.04 and most of these are passing !</div><div dir="auto"><br></div><div dir="auto">(See <a href="https://github.com/qgis/QGIS/blob/master/.ci/test_flaky.txt">https://github.com/qgis/QGIS/blob/master/.ci/test_flaky.txt</a> and <a href="https://github.com/qgis/QGIS/blob/master/.ci/test_blocklist_qt5.txt">https://github.com/qgis/QGIS/blob/master/.ci/test_blocklist_qt5.txt</a> for lists of the tests skipped on the GitHub workflows)</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div><div>Would any of these tests give a different result if I first ran "make install"?</div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Unlikely.</div><div dir="auto"><br></div><div dir="auto">I'd be interested to see a full log of the failures if you want to upload it to a gist/Pastebin/ somewhere.</div><div dir="auto"><br></div><div dir="auto">Nyall</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div><div>Im running Ubuntu 22.04, and installed all dependencies via APT as advised in the qgis build docs. I built QGIS release-3_34 from source and am now trying to test that build, by running "ctest". </div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 1, 2024 at 12:34 AM Thomas Larsen Wessel <<a href="mailto:mrvelle@gmail.com" target="_blank" rel="noreferrer">mrvelle@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Thanks both of you :) And happy new year. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Dec 31, 2023 at 11:38 PM Nyall Dawson <<a href="mailto:nyall.dawson@gmail.com" target="_blank" rel="noreferrer">nyall.dawson@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 1 Jan 2024, 6:36 am Thomas Larsen Wessel via QGIS-Developer, <<a href="mailto:qgis-developer@lists.osgeo.org" target="_blank" rel="noreferrer">qgis-developer@lists.osgeo.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">The docs (<a href="https://docs.qgis.org/3.28/en/docs/developers_guide/unittesting.html#run-your-tests" rel="noreferrer noreferrer" target="_blank">https://docs.qgis.org/3.28/en/docs/developers_guide/unittesting.html#run-your-tests</a>) specify: <i>make && make install && make test</i>. <div><br></div><div>I would rather not run make install, since I have another instance of QGIS installed via APT, and I worry running make install will somehow make a mess and leave me without a working instance. <br></div><div><br></div><div><div>But is it really necessary to run make install before make run? In fact it seems more natural to me to test before installing! </div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Try running "ctest" from your build directory. There's no need to install if doing it this way. (It's how I do all of my development)</div><div dir="auto"><br></div><div dir="auto">Nyall </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>Sincerely</div></div>
_______________________________________________<br>
QGIS-Developer mailing list<br>
<a href="mailto:QGIS-Developer@lists.osgeo.org" rel="noreferrer noreferrer" target="_blank">QGIS-Developer@lists.osgeo.org</a><br>
List info: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer noreferrer noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
Unsubscribe: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer noreferrer noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
</blockquote></div></div></div>
</blockquote></div>
</blockquote></div>
</blockquote></div></div></div>