<div dir="ltr"><div dir="ltr">Hi<div><br></div><div>I do think 1 of them is a user facing issue. It had a test added a couple of minutes ago, so it's coming in hot. It's approved now.</div><div><br></div><div>2 of the pull requests are in draft, so not ready for review.</div><div>The other 2 are not user facing bugs but improving handling of local test execution, which I don't expect to improve the quality of the release.</div><div>Out of these 4 pull requests, 3 have been opened in the last 2 days.</div><div><br></div><div>1. Given the above, and also for the reasons already outlined by our release manager Jürgen, I don't think a change in the release schedule is justified.</div><div><br></div><div>2. It would be great to have a shorter pull request queue. I am not sure however that lowering the bar to bring code into the codebase with fewer eyes looking over it is a good approach. I would prefer to try to onboard new people into this process and give incentives to actively take part in the review process. Let me take the opportunity to thank Benoit for his review. As a very active contributor in the QGIS project for 2 years already, I think we could also consider promoting him to a QGIS core committer. That would reward him for his efforts, but at the same time also give more review power to QGIS and maybe motivate others to follow his lead.</div><div><br></div><div>Kind regards</div><div>Matthias</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jun 21, 2024 at 11:15 AM Jürgen E. Fischer via QGIS-Developer <<a href="mailto:qgis-developer@lists.osgeo.org" target="_blank">qgis-developer@lists.osgeo.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Sandro,<br>
<br>
On Fri, 21. Jun 2024 at 10:22:14 +0200, Sandro Santilli wrote:<br>
> It's packaging time today but I still have 5 pull requests<br>
> pending approval reviews: <br>
> <br>
> <a href="https://github.com/qgis/QGIS/pulls/strk" rel="noreferrer" target="_blank">https://github.com/qgis/QGIS/pulls/strk</a><br>
<br>
As far as I can tell none of those are fixes for user facing bugs.<br>
<br>
<br>
> This mail is to present two requests:<br>
> <br>
> 1. To the release manager:<br>
> Can to the release be postponed to give some<br>
> time to reviewers to approve my pending PRs ?<br>
<br>
We release what's ready when it's time - unless something critical is spotted.<br>
I'd say those could well be merged and backported after the release.<br>
<br>
<br>
> 2. The the PSC:<br>
> Can the policy be reviewed once again to find a<br>
> better solution to this long-standing problem of<br>
> growing PR queue (not being a bot that closes<br>
> them after a while) ?<br>
<br>
Was that ever really discussed? AFAIK it was put in place and nobody really<br>
objected, because it is generally a good thing.<br>
<br>
But at least my contributions have gone down a lot by the introduction of these<br>
hurdles (ie. mandatory PRs, delays by CI tests and reviews and even - or mainly? -<br>
the improved stability of master, because stuff now breaks in PRs and doesn't<br>
hit the nightlies of master, where I'd fix them) as it multiplies the effort<br>
required for each of them (many mostly small ones).<br>
<br>
<br>
Jürgen<br>
<br>
-- <br>
Jürgen E. Fischer<br>
Dipl.-Inf. (FH) norBIT GmbH Tel. +49-4931-918175-31<br>
Software Engineer Rheinstraße 13 Fax. +49-4931-918175-50<br>
Geschäftsführer D-26506 Norden <a href="https://www.norbit.de" rel="noreferrer" target="_blank">https://www.norbit.de</a><br>
_______________________________________________<br>
QGIS-Developer mailing list<br>
<a href="mailto:QGIS-Developer@lists.osgeo.org" target="_blank">QGIS-Developer@lists.osgeo.org</a><br>
List info: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
Unsubscribe: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
</blockquote></div></div>