<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Le 12/12/2024 à 14:42, Denis Rouzaud
via QGIS-Developer a écrit :<br>
</div>
<blockquote type="cite"
cite="mid:CAMtsY+ZqAB_tC+46iFK9b3Z5wG2ZdZi6-0Eoca+fY4iu18Cp6A@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote gmail_quote_container">
<div dir="ltr" class="gmail_attr">Le jeu. 12 déc. 2024
à 14:22, Julien Cabieces <<a
href="mailto:julien.cabieces@oslandia.com"
moz-do-not-send="true" class="moz-txt-link-freetext">julien.cabieces@oslandia.com</a>>
a écrit :</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Oh, yes, I was looking at an old version of the
documentation. <br>
<br>
> I think it's a great tool on developer side but I have
my concerns about<br>
> the CI part. It adds a lot of automatic commit which
doesn't help when<br>
> you want to read the git history. If you want to blame
a specific line<br>
> of code, you can land in this type of commit instead
of the relevant<br>
> modification you were heading to. You can trace it
back to the pull<br>
> request but it's one more step, and it makes us even
more attached to the<br>
> GitHub platform.<br>
><br>
> Thanks to Nyall's hint, I have added the refactoring
commits to <a
href="https://github.com/qgis/QGIS/blob/master/.git-blame-ignore-revs"
rel="noreferrer" target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://github.com/qgis/QGIS/blob/master/.git-blame-ignore-revs</a><br>
> When I blame files online in Github it seems to be
working:<br>
> For instance, <a
href="https://github.com/qgis/QGIS/blame/master/src/gui/actions/qgsactionmenu.h"
rel="noreferrer" target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://github.com/qgis/QGIS/blame/master/src/gui/actions/qgsactionmenu.h</a><br>
> Last commit is the pre-commit run but you don't see it
in the blame.<br>
><br>
<br>
This works for the refactoring commits but not for all the
pre-commit<br>
commits added in Pull Requests.<br>
</blockquote>
<div><br>
</div>
<div>I see only 2 options there:</div>
<div>1. We do not auto update PR (basically same behavior than
before) and ask people to setup the pre-commit hook</div>
<div>2. We automatically add the commits to the
.git-blame-ignore-revs (possibly after merge to avoid
merging conflicts !!!) (might be an issue if it grows too
big)</div>
<div><br>
</div>
<div>Thoughts?</div>
<div><br>
</div>
<div>Denis <br>
</div>
</div>
</div>
</blockquote>
<p>Hi,<br>
</p>
<p>First of all, Thank you Denis for working on this.</p>
<p>I guess that most of the regular contributors will activate the
pre-commit hook at some point. <br>
However, this probably won't happen for first-time or casual
contributors and having a red CI because of some formatting error
can be quite frustrating. So, I would favor option 2. <br>
<br>
Based, on this discussion
(<a class="moz-txt-link-freetext" href="https://stackoverflow.com/questions/76367362/what-are-the-performance-characteristics-of-git-blame-ignore-revs">https://stackoverflow.com/questions/76367362/what-are-the-performance-characteristics-of-git-blame-ignore-revs</a>),
it looks like that the size `<a
href="https://github.com/qgis/QGIS/blob/master/.git-blame-ignore-revs"
rel="noreferrer" target="_blank" class="moz-txt-link-freetext">.git-blame-ignore-revs</a>`
does not matter.<br>
</p>
Jean<br>
</body>
</html>