<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi<br>
<br>
<div class="moz-cite-prefix">On 02/20/2016 06:40 PM, Tim Sutton
wrote:<br>
</div>
<blockquote cite="mid:9B4C37CC-FAF2-45F6-96F0-669176D01BC5@qgis.org"
type="cite">Hi
<div class=""><br class="">
<blockquote type="cite" class="">On 20 Feb 2016, at 16:38,
Matthias Kuhn <<a moz-do-not-send="true"
href="mailto:matthias@opengis.ch" class="">matthias@opengis.ch</a>>
wrote:<br class="">
<br class="">
Thanks for this Answer Nyall, my thoughts reading this mail
have been<br class="">
very similar.<br class="">
<br class="">
Our test suite has improved a lot and its stability is getting
better<br class="">
and better. I am sure that it will help a lot to smooth the
transition<br class="">
to QGIS 3, given that refactoring is very likely to introduce
small bugs<br class="">
which in turn can often be spotted by a good unit test suite.<br
class="">
<br class="">
That does not mean that our test infrastructure is perfect.
There is<br class="">
certainly a lot to improve. The most important part IMO is
increasing<br class="">
the test coverage and getting CI on Windows (and maybe other
platforms)<br class="">
or with different dependency versions. But a perfect test
infrastructure<br class="">
will be a neverending quest for a holy grail anyway :-)<br
class="">
<br class="">
I'll appreciate a broader discussion on what should be
financially<br class="">
supported by the community and the PSC (thanks for starting
this<br class="">
discussion anyway!). And then - if testing is an area to
invest -<br class="">
evaluate which parts of the testing suite needs more
attention.<br class="">
</blockquote>
<div class=""><br class="">
</div>
<div class="">Having the CI stuff going has been a huge leap
forward and with my QA PSC member hat on, I would say it is
definitely something to invest more time and effort into. </div>
</div>
</blockquote>
<br>
Happy to have your backup. We could try to bring back the "test
friday" :-)<br>
<br>
<blockquote cite="mid:9B4C37CC-FAF2-45F6-96F0-669176D01BC5@qgis.org"
type="cite">
<div class="">
<div class="">As I mentioned before though I would just like us
to be more strategic about our investments (from the PSC side
anyway) and ensure that we put more focus on other places that
urgently need support (like getting decent API docs in place
to name a random example). Thanks for all the great stuff you
have done with the test suite Matthias, looking forward to
getting more stuff done on the testing front in the future.</div>
</div>
</blockquote>
Thanks for the credits, but I have to admit that recently other
people have been much more active than me on this front!<br>
<br>
<blockquote cite="mid:9B4C37CC-FAF2-45F6-96F0-669176D01BC5@qgis.org"
type="cite">
<div class="">
<div class="">I also think we need to start thinking about GUI
testing soon - GUI testing will put a lot of the underlying
API’s to task and also ensure that fronted behaviour is
consistent from release to release (or at least that it is
consciously changed instead of unconsciously).</div>
</div>
</blockquote>
<br>
What kind of UI tests would you see as important? Are there any
recent issues which you think could have been avoided by such a unit
test?<br>
<br>
I think we need to be careful here.<br>
For once, UI issues there are normally spotted quickly in contrast
to algorithms/calculations which result in wrong outcome. E.g. the
recent strange behavior of the "control output order" checkbox in
the rendering properties.<br>
Also I think there are quite a couple of parts of our UI that could
be improved. Adding a test it will consolidate the status quo. E.g.
I think that the keyboard modifiers of the select tools would really
need to be improved. If we had a test it might keep developers from
making a pull request which proposes such an improvement because of
the feedback of a failing test.<br>
<br>
I'll be happy to hear your comments, I'm sure you have experience
with this from other projects :-)<br>
<br>
Matthias<br>
<pre class="moz-signature" cols="72">--
Matthias Kuhn
OPENGIS.ch - <a class="moz-txt-link-freetext" href="https://www.opengis.ch">https://www.opengis.ch</a>
Spatial • (Q)GIS • PostGIS • Open Source</pre>
</body>
</html>