<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /></head><body style='font-size: 10pt; font-family: Verdana,Geneva,sans-serif'>
<p>Hi Nyall,</p>
<p>This is much appreciated. Thanks so much for your continuous work and effort to increase the quality of QGIS!</p>
<p>Andreas</p>
<p>On 2017-09-26 04:31, Nyall Dawson wrote:</p>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<div class="pre" style="margin: 0; padding: 0; font-family: monospace">Hi PSC,<br /> <br /> Just reporting in that with PR #5254 [<a href="https://github.com/qgis/QGIS/pull/5254" target="_blank" rel="noopener noreferrer">1</a>], the grant work has now been<br /> completed and we're sitting as close as possible to 100% unit test<br /> coverage for the geometry primitive classes (i.e. the classes which<br /> represent the raw geometry types, such as points/multipoints/circular<br /> strings/ etc).<br /> <br /> While the purpose of this work wasn't directly to fix bugs, writing<br /> the tests has allowed me to identify and fix dozens of issues in these<br /> geometry classes. The fixes range from pedantic (e.g. crashes when<br /> requesting parts of the geometry with invalid indexes such as negative<br /> numbers), through to severe (a geometry corruption caused after<br /> converting a MultiLineString to GML which would definitely cause QGIS<br /> server to crash on certain requests).<br /> <br /> Just to ensure that there's no misconceptions here: having 100% test<br /> coverage doesn't mean the geometry classes are now bug free - rather<br /> it means that the current logic is protected so that future features,<br /> fixes, or optimisations will not cause regressions from the current<br /> behaviour.<br /> <br /> I'd like the thank the PSC once again for accepting this funding<br /> request (and the sponsors who made it possible!). In my opinion this<br /> was a crucial piece of work required to help make future QGIS releases<br /> much less likely to suffer serious regressions, so I'm very thankful<br /> that you allowed it to happen!<br /> <br /> Regards,<br /> Nyall<br /> <br /> <br /> [1] <a href="https://github.com/qgis/QGIS/pull/5254" target="_blank" rel="noopener noreferrer">https://github.com/qgis/QGIS/pull/5254</a><br /> _______________________________________________<br /> Qgis-psc mailing list<br /> <a href="mailto:Qgis-psc@lists.osgeo.org">Qgis-psc@lists.osgeo.org</a><br /> <a href="https://lists.osgeo.org/mailman/listinfo/qgis-psc" target="_blank" rel="noopener noreferrer">https://lists.osgeo.org/mailman/listinfo/qgis-psc</a></div>
</blockquote>
<p><br /></p>
</body></html>