[QGIS-trac] Re: [Quantum GIS] #605: Building pyramids causes segfault

[Quantum GIS]

#605: Building pyramids causes segfault
--------------------------------------------------------------+-------------
        Reporter:  gsherman                                   |         Owner:  timlinux     
            Type:  defect                                     |        Status:  closed       
        Priority:  critical: causes crash or data corruption  |     Milestone:  Version 1.0.0
       Component:  Rasters                                    |       Version:  0.8          
      Resolution:  fixed                                      |      Keywords:               
Platform_version:                                             |      Platform:  All          
        Must_fix:  Yes                                        |   Status_info:  0            
--------------------------------------------------------------+-------------
Comment (by msieczka):

 Replying to [comment:13 timlinux]:
 > Hi
 >
 > Its strange, because that message is propogated from GDAL as shown in
 the following snippet:
 >
 > 1601   if (!res.isNull())
 > 1602   {
 > 1603     if (res == "ERROR_WRITE_ACCESS")
 > 1604     {
 > 1605       QMessageBox::warning(this, tr("Write access denied"),
 > 1606           tr("Write access denied. Adjust the file permissions and
 try again.\n\n") );
 > 1607     }
 > 1608     else if (res == "ERROR_WRITE_FORMAT")
 > 1609     {
 > 1610       QMessageBox::warning(this, tr("Building pyramids failed."),
 > 1611           tr("The file was not writeable. Some formats do not
 support pyramid overviews. Consult      the GDAL documentation if in
 doubt.") );
 > 1612     }
 > 1613     else if (res == "FAILED_NOT_SUPPORTED")
 > 1614     {
 > 1615       QMessageBox::warning(this, tr("Building pyramids failed."),
 > 1616           tr("Building pyramid overviews is not supported on this
 type of raster.") );
 > 1617     }
 > 1618   }
 >
 > If gdal reports an error my feeling is that we should report it.

 Hmm, probably GDAL reports this error in error. It is logical to discard
 it IMO.

 > Perhaps I will just add a message saying that the warning can be ignored
 if building external
 > overviews and the dir is writable.

 I think QGIS should not bother about theis error at all and just proceed.
 There is no point in reporting that the file is not writeable if we don't
 try to modify it.

 Another small issue I noticed: even if QGIS fails to build the overviews
 for whatever reason, the icons for selected overviews change like if the
 overviews were actually created. Re-entering raster's properties shows
 they were really were not.

 >
 > Regards
 >
 > Tim

-- 
Ticket URL: <https://trac.osgeo.org/qgis/ticket/605#comment:14>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS viewer/editor supporting OGR, PostGIS, and GRASS formats