[QGIS-trac] [Quantum GIS] #1234: Suspicious retrival of active layer in dxf2shp converter

[Quantum GIS]

#1234: Suspicious retrival of active layer in dxf2shp converter
-----------------------------------------------+----------------------------
   Reporter:  mloskot                          |              Owner:  nobody
       Type:  bug                              |             Status:  new   
   Priority:  minor: annoyance or enhancement  |          Milestone:        
  Component:  Plugins                          |            Version:  HEAD  
   Keywords:  dxf2shp                          |   Platform_version:  10.5  
   Platform:  OS X                             |           Must_fix:  No    
Status_info:  0                                |  
-----------------------------------------------+----------------------------
 In file
 [source:trunk/qgis/src/plugins/dxf2shp_converter/dxf2shpconverter.cpp?rev=9053#L114
 dxf2shpconverter.cpp], lines 119-121, there are some actions implemented
 that seem to be garbage and never used:

 {{{
 QgsMapLayer *layer = mQGisIface->activeLayer();
 if (layer)
     QgsVectorLayer *lyr = (QgsVectorLayer*)layer;
 }}}

 Or, it's a kind of logical error (cast and assignment to lyr object in
 local scope of if-condition) and the idea was to use the retrieved active
 layer but bits of usage are missing.

-- 
Ticket URL: <http://trac.osgeo.org/qgis/ticket/1234>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS viewer/editor supporting OGR, PostGIS, and GRASS formats