[QGIS-trac] Re: [Quantum GIS] #3447: Grouping "add layer" toolbar buttons

Quantum GIS qgis at qgis.org
Tue Feb 1 04:46:35 EST 2011


#3447: Grouping "add layer" toolbar buttons
--------------------------------+-------------------------------------------
   Reporter:  alexbruy          |              Owner:  timlinux     
       Type:  patch             |             Status:  assigned     
   Priority:  minor: annoyance  |          Milestone:  Version 1.7.0
  Component:  GUI               |            Version:               
   Keywords:  toolbar buttons   |   Platform_version:               
   Platform:  All               |           Must_fix:  No           
Status_info:  0                 |  
--------------------------------+-------------------------------------------

Comment(by wonder):

 Replying to [comment:9 mhugent]:
 > A great benefit of bringing the dialogs into the provider libs is that
 dialogs  could link to provider classes and using specific provider
 methods. E.g. the WMS dialog could pass the WMS capabilities document
 directly to the provider. Currently, WMS dialog fetches the capabilities
 and the WMS provider needs to fetch it again because the dialog has no
 possibility to communicate with the WMS provider directly (only through
 the provider interface that is common for all providers).

 Right. I see one more benefit: the dependencies (e.g. postgresql library
 for postgis) will be only inside the provider module. Therefore if the
 user has a mismatch in the libraries, there will be a lower chance that
 QGIS will fail to start (only the affected provider won't be loaded).

 While we're at it, I would also suggest to move "new layer" functionality
 to the providers. Nowadays we can create new layer with ogr and spatialite
 backends, though the implementation is in src/app. If we had that
 functionality within providers, it would be possible to create new layers
 seamlessly also in plugins and implement "new layer" feature for further
 providers.


 > Regarding grouping the addLayer buttons: I like it because it because of
 the additional space I get. Couldn't we just export the toolbutton such
 that plugins could add their buttons there too? Additionally, we talked
 about bringing wfs, gps plugins into app (or into providers depending on
 the outcome of above discussion).

 Yes, putting the other "add layer" buttons into the group is necessary.
 Exporting the toolbutton group can be a temporary solution.

 Martin

-- 
Ticket URL: <https://trac.osgeo.org/qgis/ticket/3447#comment:10>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS viewer/editor supporting OGR, PostGIS, and GRASS formats


More information about the QGIS-trac mailing list