<div dir="ltr"><div dir="ltr">Well I'm stuck in some sort of awful loop. No idea what to do next.<div><ol type="1" style="margin-left:0.375in;direction:ltr;unicode-bidi:embed;margin-top:0in;margin-bottom:0in;font-family:Calibri;font-size:11pt">
<li value="1" style="margin-top:0px;margin-bottom:0px;vertical-align:middle"><span style="font-size:11pt">I forked the repo.</span></li><li value="1" style="margin-top:0px;margin-bottom:0px;vertical-align:middle"><span style="font-size:11pt">Downloaded the repo locally.</span></li>
<li style="margin-top:0px;margin-bottom:0px;vertical-align:middle"><span style="font-size:11pt">I created a branch.</span></li>
<li style="margin-top:0px;margin-bottom:0px;vertical-align:middle"><span style="font-size:11pt">I made a small change to the
ReadMe.</span></li>
<li style="margin-top:0px;margin-bottom:0px;vertical-align:middle"><span style="font-size:11pt">I committed and pushed back
to GitHub.</span></li>
<li style="margin-top:0px;margin-bottom:0px;vertical-align:middle"><span style="font-size:11pt">I raise a PR.</span></li>
<li style="margin-top:0px;margin-bottom:0px;vertical-align:middle"><span style="font-size:11pt">I can see the checks and action required.</span></li>
</ol></div><div><div><img src="cid:ii_jzf5gtgh1" alt="image.png" width="312" height="251" style="margin-right:0px"><br></div></div><div>7. I followed the instructions. Got this - no idea if any action is required or not. </div><div><div><img src="cid:ii_jzf5shat1" alt="image.png" width="496" height="206"><br></div></div><div>8. Did this - suspect I typed my password incorrectly but no way to be sure.</div><div><div><img src="cid:ii_jzf5tucw2" alt="image.png" width="496" height="283"><br></div></div><div>9. Now I got this.</div></div><div><img src="cid:ii_jzf5u78c3" alt="image.png" width="496" height="138"><br></div><div>How do I update my PR so that it now recognizes my sign-off? I tried to amend my commit but I guess it hasn't worked. Stumped.<br></div><div><br></div><div>I guess you only need to set this up once and then for all future commits it will automatically add my signature. Is that true?</div><div><br></div><div>Sorry for all the screenshots - wonder if this email will make it through or go to the holding yard. </div><div><br></div><div>Cheers</div><div>Felicity <br></div><div><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 16, 2019 at 8:13 PM Jo Cook <<a href="mailto:jo.k.cook@gmail.com" target="_blank">jo.k.cook@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi Erin et al,</div><div><br></div><div>I've just submitted a pull request to test this, initially without any signature, and it worked a treat. I like the way it explains exactly what you need to do to fix the problem, and that once you make the changes at the command line, the tests pass, so no more faffing in the web interface. My only observation is that we probably do need to expand on the text to indicate why it's asking for the sign off. I'd also like to see this combined with pull request templates, which I think would give us the full solution.</div><div><br></div><div>Thanks for setting it up! I'd be more than happy for it do be permanent but maybe we should wait for a few other people to test first.</div><div><br></div><div>Jo<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 13, 2019 at 10:17 PM Erin McKean <<a href="mailto:emckean@google.com" target="_blank">emckean@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi folks!<div><br></div><div>I've installed the Probot DCO (<a href="https://github.com/probot/dco" target="_blank">https://github.com/probot/dco</a>) on the templates repository. </div><div><br></div><div>If people could send test pull requests both with and without the signature requirement that would be great!</div><div><br></div><div>Also, please confirm that we're all okay with the wording of the DCO included in the bot. If we are, someone should move that we make this test permanent. :)</div><div><br></div><div>Thanks!<br><br>Erin</div><div><div><br></div>-- <br><div dir="ltr" class="m_-6502007227876554628gmail-m_8260827064576156898gmail-m_-4633761794171200497gmail_signature"><div dir="ltr"><div><div dir="ltr"><div style="line-height:1.5em;padding-top:10px;margin-top:10px;color:rgb(85,85,85);font-family:sans-serif"><span style="border-width:2px 0px 0px;border-style:solid;border-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Erin McKean |</span><span style="border-width:2px 0px 0px;border-style:solid;border-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Developer Relations Program Manager, Open Source Strategy |</span><span style="border-width:2px 0px 0px;border-style:solid;border-color:rgb(0,153,57);padding-top:2px;margin-top:2px"> <a href="mailto:emckean@google.com" target="_blank">emckean@google.com</a> |</span><span style="border-width:2px 0px 0px;border-style:solid;border-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> she/her</span></div><br></div></div></div></div></div></div>
_______________________________________________<br>
SeasonOfDocs mailing list<br>
<a href="mailto:SeasonOfDocs@lists.osgeo.org" target="_blank">SeasonOfDocs@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/seasonofdocs" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/seasonofdocs</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_-6502007227876554628gmail-m_8260827064576156898gmail_signature">------------------------<br><a href="http://about.me/jocook" target="_blank">http://about.me/jocook</a></div>
_______________________________________________<br>
SeasonOfDocs mailing list<br>
<a href="mailto:SeasonOfDocs@lists.osgeo.org" target="_blank">SeasonOfDocs@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/seasonofdocs" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/seasonofdocs</a><br>
</blockquote></div></div>