[fdo-dev] [Proposal] FGF<->WKB converters as common utils

[Traian Stanev]

Reuse is definitely good. Therefore I have no problem with FDO Geometry
reusing my function. :)

Traian


-----Original Message-----
From: Pierre Dalcourt 
Sent: Tuesday, August 08, 2006 3:11 PM
To: dev at fdo.osgeo.org
Subject: RE: [fdo-dev] [Proposal] FGF<->WKB converters as common utils


I like Mateusz's suggestion.  But I would suggest movnig this stuff to
someplace more global such as ProvidersCommon, where multiple providers
(GenericRDBMS-based or not) can share the same code instead of each
having their own copy.  Traian, wouldn't you prefer re-using (and
possibly enhancing) existing code rather than reinventing the wheel? :-)

Pierre

-----Original Message-----
From: Traian Stanev
Sent: August 8, 2006 3:07 PM
To: dev at fdo.osgeo.org
Subject: RE: [fdo-dev] [Proposal] FGF<->WKB converters as common utils


I also have functions to do that conversion in the OGR provider source
code. At least, I have WkbToFgf, and will soon be adding the reverse,
when I add write support to the OGR provider. Search for
OgrConnection::Wkb2Fgf in the attached file.

Traian


-----Original Message-----
From: Mateusz Loskot [mailto:mateusz at loskot.net] 
Sent: Tuesday, August 08, 2006 3:03 PM
To: dev at fdo.osgeo.org
Subject: [fdo-dev] [Proposal] FGF<->WKB converters as common utils

Hi,

I'd like to present small proposal about constituting FGF<->WKB
converters as common utilities.

Currently, I know about two procedures that can be used to convert
geometries between FGF and OGC WKB formats:

GeometryFromWkb() and WkbFromGeometry()

Both functions are coupled with MySQL driver for RDBI layer:

fdordbms/trunk/Providers/GenericRdbms/Src/MySQL/Driver/Geometry.h
fdordbms/trunk/Providers/GenericRdbms/Src/MySQL/Driver/Geometry.c

I see these functions may be used in PostGIS driver too, because PostGIS
also operates on OGC WKB format.
So, my proposal is to move Geometry.h and Geometry.c to a common
location, for example to:

fdordbms/trunk/Providers/GenericRdbms/Inc/Util/Geometry.h
fdordbms/trunk/Providers/GenericRdbms/Src/Util/Geometry.c

What do you think?

p.s. Should I report such proposals to Project Tracker as 'enhancements'
or posting it here is fine?

Best regards
--
Mateusz Loskot
http://mateusz.loskot.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at fdo.osgeo.org For additional
commands, e-mail: dev-help at fdo.osgeo.org




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at fdo.osgeo.org
For additional commands, e-mail: dev-help at fdo.osgeo.org