[fdo-dev] dbi_* functions

[Brent Robinson]

A lot of the DBI functions in DbiConnection.cpp were kept around for the
earlier stages of when GenericRdbms was created. Since a lot of the code
was taken from the Oracle provider, the calls were kept around to allow
GenericRdbms to compile.

INVOKE_DBI_FUNC is defined to throw an exception. As we activated more
GenericRdbms code, any calls to dbi needed to be replaced by something
else. The exceptions provided a reminder if we missed anything. 

Now that GenericRdbms is more mature, we might be at the point where
these dbi calls can be removed from GenericRdbms. However, it would take
a bit of investigation to see how much work would be involved.

-----Original Message-----
From: Barbara Zoladek 
Sent: Monday, August 21, 2006 3:47 PM
To: mateusz at loskot.net
Cc: dev at fdo.osgeo.org
Subject: RE: [fdo-dev] dbi_* functions


Yes, you're right.

Barbara.

> -----Original Message-----
> From: Mateusz Loskot [mailto:mateusz at loskot.net]
> Sent: Monday, August 21, 2006 3:35 PM
> To: dev at fdo.osgeo.org
> Subject: Re: [fdo-dev] dbi_* functions
> 
> Barbara,
> 
> Thank you for your answer.
> So, am I correct that DbiConnection class is a general RDBMS
> connection class, used all RDBMS providers, but
> it also includes subset of Oracle-only API,
> like all dbi_* member functions?
> 
> Best regards
> Mat
> 
> Barbara Zoladek wrote:
> > Hi Mateusz,
> >
> > The dbi functions are only used for the Oracle provider.
> >
> > Thanks,
> > Barbara.
> >
> >> -----Original Message-----
> >> From: Mateusz Loskot [mailto:mateusz at loskot.net]
> >> Sent: Monday, August 21, 2006 1:59 PM
> >> To: dev at fdo.osgeo.org
> >> Subject: [fdo-dev] dbi_* functions
> >>
> >> Hi,
> >>
> >> I have one more question about Dbi.
> >> Where dbi_* functions implemented?
> >>
> >> Here is small example from the
> >> Providers/GenericRdbms/Src/Fdo/Connection/DbiConnection.cpp file:
> >>
> >> int DbiConnection::dbi_ver_dbase( char *db_name, int  *exists)
> >> {
> >>     INVOKE_DBI_FUNC(dbi_ver_dbase( mContext, db_name, exists) );
> >> ------------------^^^^^^^^^^^^^^^^^
> >> }
> >>
> >> Where is this DbiConnection::dbi_ver_dbase() call delegated?
> >> I grepped through all FDO + FDORDBMS sources and nothing was found.
> >>
> >> Second question, do I need to bother/implement anything from dbi_*
> >> for my PostGIS FDO provider?
> >>
> >> Best regards
> >> --
> >> Mateusz Loskot
> >> http://mateusz.loskot.net
> >>
> >>
---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe at fdo.osgeo.org
> >> For additional commands, e-mail: dev-help at fdo.osgeo.org
> >
> >
> >
> 
> 
> --
> Mateusz Loskot
> http://mateusz.loskot.net
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe at fdo.osgeo.org
> For additional commands, e-mail: dev-help at fdo.osgeo.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at fdo.osgeo.org
For additional commands, e-mail: dev-help at fdo.osgeo.org