[fdo-dev] FDO bugs, fixes and reviewing

[Dan Stoica]

It may be much quicker and easier but it may be not the correct thing to
do.
Say somebody else is doing a sync and runs into problems. Then he/she
will want to revert the changes to the previous revision - which is not
a pleasant thing to do. 

The goal of the review is to a) get good ideas for free and b) minimize
the risk of breaking existing code.

As for " having to zip up source files with correct paths is a pain"
there is an utility \GRANITE\packchanges.bat that eases the pain :-) 

Just another opinion...

Dan.



-----Original Message-----
From: Traian Stanev 
Sent: Thursday, August 24, 2006 1:52 PM
To: dev at fdo.osgeo.org
Subject: RE: [fdo-dev] FDO bugs, fixes and reviewing



Isn't it much quicker and easier to use a policy like MapGuide's where
reviews are done post submission? The advantage of that is that it saves
time on both sides (having to zip up source files with correct paths is
a pain) -- instead it's much easier to look at the commit log that gets
sent automatically by subverion with all the diffs of the submission.
Just a suggestion...


Traian
 

-----Original Message-----
From: Greg Boone 
Sent: Thursday, August 24, 2006 1:42 PM
To: dev at fdo.osgeo.org
Subject: RE: [fdo-dev] FDO bugs, fixes and reviewing

See inline...

-----Original Message-----
From: Frank Warmerdam (External)
Sent: Thursday, August 24, 2006 1:11 PM
To: dev at fdo.osgeo.org
Subject: Re: [fdo-dev] FDO bugs, fixes and reviewing

Greg Boone wrote:
> I reviewed the change and it looks good. Next time you can make me the

> reviewer in the Artifact send the changed files to me before
submitting.

Greg,

OK, I'll try and keep that in mind.  By the way, is that a "can" as in
"may"
or more as in "should"?
[GB] As in "should"

And do you want a chance to review-before-committing even on minor items
or is this more aimed a big things?  
[GB] I am more concerned with new code or bug fix code. Fixing build
issues or unit tests can be reviewed post submission.

I will, eventually, have lots of changes for the fdogdal provider since
it essentially is still not in working condition.  If you need to review
before committing, I'll likely just accumulate them all and then give
you a chance to review when I think I'm all done.
[GB] Ok

Is there an "FDO Development Policy" document or something to that
effect around about stuff like this?  I think this will eventually be
necessary to make things clear for outside contributors.
[GB] Yes, we need a clarification but that will not happen in the next
couple of weeks.

Best regards,
-- 
---------------------------------------+--------------------------------
------
I set the clouds in motion - turn up   | Frank Warmerdam,
warmerdam at pobox.com
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush    | President OSGeo,
http://osgeo.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at fdo.osgeo.org For additional
commands, e-mail: dev-help at fdo.osgeo.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at fdo.osgeo.org For additional
commands, e-mail: dev-help at fdo.osgeo.org




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at fdo.osgeo.org
For additional commands, e-mail: dev-help at fdo.osgeo.org