[fdo-internals] automake/autoconf/libtool preferred version?

Greg Boone greg.boone at autodesk.com
Sun Feb 11 16:34:26 EST 2007


Your proposed change looks ok.

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org
[mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Frank
Warmerdam (External)
Sent: Sunday, February 11, 2007 2:49 PM
To: FDO Internals Mail List
Subject: Re: [fdo-internals] automake/autoconf/libtool preferred
version?

Traian Stanev wrote:
> I remember having to fix this exact thing for my 64 bit build too, but
I 
> redeclared the variable len to be the correct type (i.e. not FdoSize, 
> but whatever int Xerces wanted).

Traian,

Right, on reflection I came to the same conclusion.  I adjusted things
to this:

warmerda at amd64[9]% svn diff FeaturePropertyReaderImpl.cpp
Index: FeaturePropertyReaderImpl.cpp
===================================================================
--- FeaturePropertyReaderImpl.cpp       (revision 2498)
+++ FeaturePropertyReaderImpl.cpp       (working copy)
@@ -532,7 +532,7 @@
          break;
      case ParsingState_base64Binary:
          {
-            FdoSize len;
+            unsigned int len;
              XMLByte* decoded =
XERCES_CPP_NAMESPACE::Base64::decode((const 
XMLByte*)(const char*)m_dataProperty, &len);
              if (decoded != NULL) {
                  curFeatureHandler->FeatureBinaryData(m_featureContext,

decoded, len);

Are there any objections to me committing tihs change in trunk?

Best regards,
-- 
---------------------------------------+--------------------------------
------
I set the clouds in motion - turn up   | Frank Warmerdam,
warmerdam at pobox.com
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush    | President OSGeo,
http://osgeo.org

_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals



More information about the fdo-internals mailing list