[fdo-internals] Code Submission Notification: Ports from 3.2.x branch to trunk

[Gavin Cramer]

The following changes has been ported from the 3.2.x branch to the
trunk...
 
All Summaries:
FDO: Fix Geometry pool sharing objects between threads
ODBC: Connect to Access on Vista
ODBC: Primary keys in views
 
---------------------------------------------------------
 
Summary:
FDO: Fix Geometry pool sharing objects between threads

Reviewed by:
Dan Stoica, Brent Robinson


Description:  

 
This changes the geometry object pool to not share ownership with
returned 
values.  Since a caller could access a geometry from a different thread,
the 
previous method was not thread-safe.  Geometry objects now use the same
method 
as pooled FdoByteArray values, which is to only be pooled when otherwise
unused.   
 
FdoByteArray values now have an extra pool.  Depending on the order of
object 
freeing in client code, some FGF-bearing values were being missed.
Values over  
8KB will still not be pooled, in order to avoid longer-than-needed
memory 
consumption from pooling large allocations (such as rasters).
 
---------------------------------------------------------
 
Summary:
ODBC: Connect to Access on Vista

 
Reviewed by:
Dan Stoica

Description:  

 
This works around a regression in the Microsoft ODBC driver for Access,
on 
Microsoft Vista (Business Edition).
 
The function to get information about ODBC schema names fails on Vista.
Access 
doesn't support schemas anyway, so the ODBC Provider code was changed to
proceed 
with the no-schema logic if the ODBC API function call fails.
 
Also, a SqlCmdTest unit test that incorrectly cast a DateTime value was
fixed.

---------------------------------------------------------
 
Summary:
ODBC: Primary keys in views
 
Reviewed by:
Brent Robinson


Description:  

 
This follows on revision 2519, which makes views visible in a default
schema 
description.  This change makes the ODBC Provider attempt to look up
primary 
keys for views, as it already does for tables.
 
The various 3rd-party ODBC drivers typically do NOT identify primary
keys.  
However, at least one of the internal workarounds is useful --
autogenerated 
column values will be considered as primary keys, if present.  A new
unit test 
exercises this in Microsoft Access.  Further workarounds may be added.
 
---------------------------------------------------------
 
Log:

 
Revision: 2550
Author: gavincramer
Date: 1:43:18 PM, Friday, February 16, 2007
Message:
(Ports from 3.2.x branch to trunk)
FDO: Fix Geometry pool sharing objects between threads
ODBC: Connect to Access on Vista
ODBC: Primary keys in views
----
Modified : /trunk/Fdo/Unmanaged/Inc/Geometry/Fgf/Factory.h
Modified : /trunk/Fdo/Unmanaged/Src/Common/ArrayHelper.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Fdo/Fdo.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/CurvePolygon.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/CurvePolygon.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/CurveString.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/CurveString.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/GeometryFactory.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/GeometryFactory2.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/GeometryImpl.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/GeometryThreadData.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/LineString.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/LineString.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/LinearRing.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/LinearRing.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiCurvePolygon.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiCurvePolygon.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiCurveString.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiCurveString.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiGeometry.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiGeometry.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiLineString.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiLineString.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiPoint.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiPoint.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiPolygon.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/MultiPolygon.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Point.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Point.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Polygon.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Polygon.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Pool.h
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Util.cpp
Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Util.h
Modified :
/trunk/Providers/GenericRdbms/Src/ODBC/SchemaMgr/Ph/DbObject.cpp
Modified :
/trunk/Providers/GenericRdbms/Src/ODBC/SchemaMgr/Ph/DbObject.h
Modified : /trunk/Providers/GenericRdbms/Src/ODBCDriver/users_.c
Modified :
/trunk/Providers/GenericRdbms/Src/UnitTest/Common/FdoSqlCmdTest.cpp
Modified : /trunk/Providers/GenericRdbms/Src/UnitTest/MSTest.mdb
Modified :
/trunk/Providers/GenericRdbms/Src/UnitTest/Odbc/OdbcBaseSetup.cpp
Modified :
/trunk/Providers/GenericRdbms/Src/UnitTest/Odbc/OdbcFdoSelectTest.cpp
Modified :
/trunk/Providers/GenericRdbms/Src/UnitTest/Odbc/OdbcFdoSelectTest.h
 
---------------------------------------------------------
 
Gavin Cramer
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/fdo-internals/attachments/20070216/bc7e811d/attachment.html