[fdo-internals] xmin and xmax are reserved keywords

[Gavin Cramer]

Yes, it looks like you have the right idea there.

Does PostGIS Provider support ApplySchema command?  If so, you'd want to
test the full round-trip (ApplySchema followed by DescribeSchema) to
make sure that there aren't any other places that would be affected.

Gavin
 

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org
[mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Mateusz
Loskot
Sent: Monday, January 15, 2007 12:31 PM
To: FDO Internals Mail List
Subject: Re: [fdo-internals] xmin and xmax are reserved keywords

Gavin Cramer wrote:
> Hi Mateusz.  I was just chatting with Brent, and it might be a lesser
> change to make a provider-specific override to the setup functions for
> the reader/writer classes (and an updated fdo_sys.sql as Brent
mentions
> below).

Gavin,

Sounds interesting...

> The "xmin" etc. names that appear in the code are mostly just internal
> query field tags that could stay the same.  They are merely defaults
to
> the actual column names.  We'd need to make some currently non-virtual
> methods virtual, such as the FdoSmPhMgr factory function for
> FdoSmPhSpatialContextGroupWriter, but such changes are very minor.
> 
> Is this proposal less work?

It seems to be, but please confirm if my understanding of this
new ideas is correct.

As I understand, the idea is to make it possible to override
behavior of FdoSmPhSpatialContextGroupWriter::MakeRow() and use
provider-specific column names there.

Am I correct?

If my understanding is correct, it seems I need function
FdoSmPhMgr::GetSpatialContextGroupWriter() as virtual
+ I need to define PostGIS-specific
specialization of FdoSmPhSpatialContextGroupWriter class.

Am I following you?

Cheers
-- 
Mateusz Loskot
http://mateusz.loskot.net
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals