[fdo-internals] ArcDE: fix spatial reference SRID issue, misc clean-ups

[Pierre Dalcourt]

- Fixed ArcSDE spatial reference SRID issue:

This defect was fixed before, but broke due to recent
performance-enhancement 

changes.  This fix only applies to SQL Server SDE databases where

calls to SE_spatialref_get_info_list() fail (for unknown reasons).  In
such a scenario, 

this fix changes the way SRID's are retrieved, by looking in the cached
SRID array instead of calling SE_spatialrefinfo_get_srid().

We cannot rely on SE_spatialrefinfo_get_srid() since the SRID is never
set because there is no

SE_spatialrefinfo_SET_srid() method for us to call.

 

- Misc cleanups:

            - removed ArcSDE's BasicConnectionTests::Command(); now use
FdoCommonMiscutil::FdoCommandTypeToString() instead.

            - added the 3 missing datastore command names to
FdoCommonMiscutil::FdoCommandTypeToString()

            - fixed setuptestdata.perl: was missing {} brackets around
if/else statements at line 192, which caused Perl compiler errors.

            - moved a bunch of repeatedly-included headers to stdafx.h :

                        malloc.h

                        string.h

                        math.h

                        sdeerno.h

                        typeinfo

 

- added some printfs to measure performance of SelectTests::simple() and
BasicSchemaTests::describe()

 

TESTING PERFORMED:

SelectTests, BasicSchemaTests, SpatialContextTests were ran both with
and 

without a hack to force the "alternate code stream" that reads SDE
Spatial 

References using pure SQL instead of via the SDE API.

 

 

FILES MODIFIED:

 

******Fdocore******

Modified : Utilities/Common\Src\FdoCommonMiscUtil.cpp

 

******ArcSDE******

Modified : Providers/ArcSDE/Src\UnitTest\UnitTest.vcproj

Modified : Providers/ArcSDE/Src\UnitTest\SelectTests.cpp

Modified : Providers/ArcSDE/Src\UnitTest\BasicConnectionTests.cpp

Modified : Providers/ArcSDE/Src\UnitTest\BasicSchemaTests.cpp

Modified :
Providers/ArcSDE/Src\Provider\ArcSDERollbackLongTransactionCommand.cpp

Modified :
Providers/ArcSDE/Src\Provider\ArcSDEActivateLongTransactionCommand.cpp

Modified :
Providers/ArcSDE/Src\Provider\ArcSDELongTransactionConflictDirectiveEnum
erator.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEProvider.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDESpatialContextReader.h

Modified :
Providers/ArcSDE/Src\Provider\ArcSDEDeactivateLongTransactionCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEDeleteCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEUtils.h

Modified : Providers/ArcSDE/Src\Provider\ArcSDEFilterToSql.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDELockedObjectReader.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEFeatureReader.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDETransaction.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDESpatialContextReader.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDESpatialContextUtility.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEDataReader.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEAcquireLockCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEConnection.h

Modified : Providers/ArcSDE/Src\Provider\ArcSDEDestroySchemaCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDELockOwnersReader.cpp

Modified : Providers/ArcSDE/Src\Provider\stdafx.h

Modified : Providers/ArcSDE/Src\Provider\ArcSDESQLDataReader.cpp

Modified :
Providers/ArcSDE/Src\Provider\ArcSDECommitLongTransactionCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDESelectCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEUpdateCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEGetLockOwnersCommand.cpp

Modified :
Providers/ArcSDE/Src\Provider\ArcSDEGetLongTransactionsCommand.cpp

Modified :
Providers/ArcSDE/Src\Provider\ArcSDECreateLongTransactionCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDELongTransactionReader.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDESpatialContextUtility.h

Modified : Providers/ArcSDE/Src\Provider\ArcSDELockConflictReader.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEConnection.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEGetLockInfoCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEApplySchemaCommand.cpp

Modified :
Providers/ArcSDE/Src\Provider\ArcSDESelectAggregatesCommand.cpp

Modified :
Providers/ArcSDE/Src\Provider\ArcSDEGetLockedObjectsCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEReleaseLockCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDESchemaManager.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDESQLCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEUtils.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEDescribeSchemaCommand.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEReader.cpp

Modified : Providers/ArcSDE/Src\Provider\ArcSDEInsertCommand.cpp

Modified : Providers/ArcSDE/TestData\SetupTestData.perl

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/fdo-internals/attachments/20070123/0b96ed70/attachment.html