[fdo-internals] RFC Reminder

[Dan Stoica]

Hi,

 

a)       I have a problem understanding what FdoFunctionClassType_Intrinsic stands for. That is, the name is not intuitive and it is not documented.

According to the examples, wouldn’t be better to say FdoFunctionClassType_Geometry instead? This way, future geometry utilities will have their own place.

 

b)       FdoFunctionClassType_Custom. Can you give an example?

 

c)       I believe using “Group” instead of “ClassType” would be more appropriate.

 

Thanks,

Dan.

 

From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Thomas Knoell
Sent: Monday, July 30, 2007 7:31 PM
To: fdo-internals at lists.osgeo.org
Subject: Re: [fdo-internals] RFC Reminder

 

Hi Greg

Thanks for the comment. I'll address your concerns and update the RFC.

Thanks

  Thomas

--------------------------
Sent from my BlackBerry Wireless Handheld (www.BlackBerry.net)


----- Original Message -----
From: fdo-internals-bounces at lists.osgeo.org <fdo-internals-bounces at lists.osgeo.org>
To: FDO Internals Mail List <fdo-internals at lists.osgeo.org>
Sent: Mon Jul 30 19:24:23 2007
Subject: RE: [fdo-internals] RFC Reminder

1) In order to remain consistent with the rest of the FDO API



enum FdoFunctionClass {

                 FdoFunctionClass_Aggregate,

                 FdoFunctionClass_Conversion,

                 FdoFunctionClass_Custom,

                 FdoFunctionClass_Date,

                 FdoFunctionClass_Intrinsic,

                 FdoFunctionClass_Math,

                 FdoFunctionClass_Numeric,

                 FdoFunctionClass_String,

                 FdoFunctionClass_Unspecified

}  //  enum FdoFunctionClass



Should use the word Type in its naming convention as follows….



enum FdoFunctionClassType {

                 FdoFunctionClassType_Aggregate,

                 FdoFunctionClassType_Conversion,

                 FdoFunctionClassType_Custom,

                 FdoFunctionClassType_Date,

                 FdoFunctionClassType_Intrinsic,

                 FdoFunctionClassType_Math,

                 FdoFunctionClassType_Numeric,

                 FdoFunctionClassType_String,

                 FdoFunctionClassType_Unspecified

}  //  enum FdoFunctionClassType





NOTE: Subsequent required changes to the other API methods, documentation, etc, to indicate Type, is omitted for brevity sake.



2) Can you add the required documentation for the public Create functions explaining the parameters, return types, usage, etc.



3) Can you add simple code examples demonstrating how the new methods will be used?



4) Can you add details on how the Managed API will have to be updated to reflect the proposed changes?



Greg



From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Thomas Knoell
Sent: Friday, July 27, 2007 11:13 AM
To: FDO Internals Mail List
Subject: [fdo-internals] RFC Reminder



Hi everyone



As indicated in an e-mail dated July 17th, FDO RFC 5 (http://trac.osgeo.org/fdo/wiki/FDORfc5) had been posted and is ready for review. Please complete the review of the RFC and comment on it by end-of-day Tuesday, July 31st. If no changes are required, it is my intent to motion that a vote for the acceptance of RFC5 be made and subsequently voted on by the PSC.



Thanks



  Thomas




-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/fdo-internals/attachments/20070731/9a6ff0cd/attachment.html