[fdo-internals] PATCH: Connection-Properties of various providers

[Aaron Pieler]

WFS,WMS,Oracle
	I checked the providers. 
	They aren't really doing anything with the "IsProtected" value.
	Maybe i missed something but why should they evaluate this value if
the provider itself defines it.
	As I see it these values(IsRequired, IsProtected, IsEnumerable,...)
are merely values for ui-purposes in applications/components which are using
the fdo-providers.

ODBC: 
	I set the IsRequired for DSN and ConnectionString to false.
	I'd like to think that the changes with the Enumeration-thingie for
GenerateDefaultGeometryProperty is okay.

If the changes to SHP and SQL Server Spatial are also okay I would like to
post the patch or commit the changes(provided I get write access to the
svn-repository). 
How do you want to proceed?


-----Ursprüngliche Nachricht-----
Von: fdo-internals-bounces at lists.osgeo.org
[mailto:fdo-internals-bounces at lists.osgeo.org] Im Auftrag von Greg Boone
Gesendet: Montag, 6. April 2009 17:17
An: FDO Internals Mail List
Betreff: RE: [fdo-internals] PATCH: Connection-Properties of various
providers


RE:

    WFS, WMS, King-Oracle:
    * Password: IsProtected = true;

-> This makes sense. We would need to double check how the providers are 
-> implemented, just to make sure that changing these values would not 
-> have any unintended consequences.

Greg


-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org
[mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Greg Boone
Sent: Monday, April 06, 2009 11:10 AM
To: FDO Internals Mail List
Subject: RE: [fdo-internals] PATCH: Connection-Properties of various
providers

RE: 

	ODBC:
	* DataSourceName: IsRequired = true
	* ConnectionString: IsRequired = true

A user can connect using either DSN or ConnectionString, so they cannot be
marked as required.

Greg

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org
[mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Aaron Pieler
Sent: Monday, April 06, 2009 9:14 AM
To: fdo-internals at lists.osgeo.org
Subject: [fdo-internals] PATCH: Connection-Properties of various providers

Hello everyone,

In an attempt to unifiy the behaviour of the connection properties i made
following changes to the providers:

ODBC:
* DataSourceName: IsRequired = true
* ConnectionString: IsRequired = true
* GenerateDefaultGeometryProperty: IsEnumerable = true; EnumerableValues=
true, false

SHP:
* DefaultFileLocation: IsRequired = true

WFS, WMS, King-Oracle:
* Password: IsProtected = true;

SQL Server Spatial:
* ConnectionString:  IsProtected == false (Why is the ConnectionString
currently handled like a password? Is this really necessary?)

OGR:
Here I am not sure and didn't change anything so far. 
Currently IsEnumerable is set to false. Why does the OgrProvider not handle
this like the SDF-Provider does?


Does someone have an objection against something or comments about
something? Would these changes do harm to applications currently using FDO?

Thanks





_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals