[fdo-internals] Patch for const char* error

[Greg Boone]

3.5 already contains the formal FDO API char* -> const char* changes. I have no issue with making the changes Helio suggests. Sounds like a good idea.

Greg

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Traian Stanev
Sent: Tuesday, June 02, 2009 10:17 AM
To: fdo-internals at lists.osgeo.org
Subject: RE: [fdo-internals] Patch for const char* error

Hi Helio,


Yes, I agree, I have also noticed the large number of warnings due to non-const correct calls in the Nls message functions. I remember that you submitted a patch for this a while back for 3.4, but it was not checked in since it would introduce a binary incompatibility between minor versions. I think it should be ok to fix them now that we are on 3.5, but let's make sure Greg is ok with that.

Traian


-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Helio Chissini de Castro
Sent: Tuesday, June 02, 2009 10:09 AM
To: fdo-internals at lists.osgeo.org
Subject: [fdo-internals] Patch for const char* error

Hi

gcc >= 4.4. now issues formal errors for some invalid conversions.
For now this patch is only one cpp, but fdo has some large amount of usage of
char* where should be const char*. Would be a good idea fix this "warning", even good for perfomance reason.

[]'s

--
Helio Chissini de Castro
KDE Developer
Brasil/South America Primary Contact