[fdo-internals] RE: Patch for ticket 827 (xalan build fixes for ubuntu)

[Greg Boone]

OK.

The changes look good for Branches/3.7 and the Trunk.

Greg 

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Wednesday, April 11, 2012 12:30 PM
To: fdo-internals at lists.osgeo.org
Subject: [fdo-internals] RE: Patch for ticket 827 (xalan build fixes for ubuntu)

If we follow the gcc bug that changed this behaviour:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33558

It was that the C++ standard does not allow the 'mutable' specifier to be applied to reference members. Builds of current/previous xalan releases must've obviously been built with more lenient compilers which overlooked this part of the standard, so I'd guess the developers didn't know such code was illegal.

As for whether such changes have been made back upstream, it's been in the xalan trunk for a year and a half now (relevant JIRA issues are XALANC-643 and XALANC-703):

One of the patched headers (with mutable keyword removed):
http://svn.apache.org/viewvc/xalan/c/trunk/src/xalanc/PlatformSupport/XSLException.hpp?view=markup&sortdir=down

One of the patched Makefile.in files (with re-ordered linker flags at lines 177, 185, 195):
http://svn.apache.org/viewvc/xalan/c/trunk/src/xalanc/Makefile.in?view=markup&sortdir=down

- Jackie

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-ticket-827-xalan-build-fixes-for-ubuntu-tp4831505p4832739.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals