[fdo-internals] RFC 68 for review

[Andy Zhang]

Hi Bruno, 

It looks like you are NOT working on the latest version of Providers\GenericRdbms\Src\PostGis\SchemaMgr\Ph\SpatialIndex.cpp. I removed the GIST_GEOMETRY_OPS in revision #6796 when implementing ticket #764.

PostGis 1.5 works without this parameter. Below statement is from PostGis 2.0 manual. 
"Some older applications that as part of the process create tables and indexes, explicitly referenced the operator class name. This was unnecessary if you want the default 2D index."
So we think it is safe to remove the parameter.

Thanks
Andy

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Greg Boone
Sent: Thursday, September 12, 2013 7:58 AM
To: FDO Internals Mail List
Subject: Re: [fdo-internals] RFC 68 for review

Actually, the logic can be reversed, since 2.0 is the new standard.

- Execute the command without using GIST_GEOMETRY_OPS.
- If the command fails, re-execute using GIST_GEOMETRY_OPS. 
- If the error persists, error out.

Greg

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Greg Boone
Sent: Wednesday, September 11, 2013 11:54 AM
To: FDO Internals Mail List
Subject: Re: [fdo-internals] RFC 68 for review

Re: (b) 

The provider still needs to support 1.x. I thought we added if/else conditions or "fail-over" conditions to accommodate this need. For example, 
- Execute the command using GIST_GEOMETRY_OPS.
- If the create index command fails using GIST_GEOMETRY_OPS, re-execute without this parameter. 
- If the error persists, error out. 

Greg

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Bruno Scott
Sent: Wednesday, September 11, 2013 11:45 AM
To: fdo-internals at lists.osgeo.org
Subject: Re: [fdo-internals] RFC 68 for review

Hi Greg

(a) What is the difference between the following 2 functions? They seem duplicates of each other. SupportsAnsiQuotes() is never used. 

the SupportsAnsiQuotes function is used in all providers derived from the
genericrdbms(sqlserver,odbc...)
and it tells what it does. In the specific case of PostGis, PostGIS actually does support Ansi Quotes But is is the easiest way for having the generic part of the provider to remove the quotes. All the code i've added use the IsCaseSensitive function, i think it's clearer this way.


(b) Why did you remove the use of GIST_GEOMETRY_OPS below?

This is not related to the CaseSensitive patch. The GIST_GEOMETRY_OPS does not exist anymore in version 2.*. Only the 2.* runs on 64 bit server. The GIST_GEOMETRY_OPS key word makes the Fdo Create index failed. Removing it make it to work with the default values.

(c) Can you update your indent/tab to be 4 spaces? That is the expected standard. Also. all tab characters should be replaced by 4 spaces.

oops, i will post another patch tomorrow

(d) I believe you have a memory leak. New and no subsequent delete.

I will check this


Thanks for your comments Greg

Bruno



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/RFC-68-for-review-tp5077290p5077327.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals