[fdo-internals] Please review: VS 2015 migration - open source provider

[Karsten Winter]

Hi all

I'm currently migrating the projects to Visual Studio 2015.
Some errors occur with the new compiler for which I would like to get a review for the solution. The 4th part is about FDO open source provider.

Shape:

Providers\SHP\Src\Provider\stdafx.h
error C2338: <hash_map> is deprecated and will be REMOVED. Please use <unordered_map>. You can define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning
Solution:
-> use "unordered_map" instead of "hash_map"

Providers\SHP\Src\ShpRead\ShapeFile.cpp
error C3861: 'max': identifier not found
Solution:
-> #include <algorithm>

SDF:

Providers\SDF\Src\Utils\PropertyIndex.h
error C2338: <hash_map> is deprecated and will be REMOVED. Please use <unordered_map>. You can define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning
Solution:
-> remove include of not required <hash_map>

Providers\SDF\Src\Provider\BinaryReader.h
Providers\SDF\Src\Provider\ExInfoDb.h
Providers\SDF\Src\Provider\SchemaDb.h
Providers\SDF\Src\Provider\SdfConnection.cpp
Providers\SDF\Src\Provider\SdfConnection.h
Providers\SDF\Src\Provider\SdfExtHashMap.h
Providers\SDF\Src\Provider\SdfSchemaMergeContext.cpp
Providers\SDF\Src\Provider\SdfSchemaMergeContext.h
Providers\SDF\Src\Provider\TableReformatter.h
error C2338: <hash_map> is deprecated and will be REMOVED. Please use <unordered_map>. You can define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning
Solution:
-> use "unordered_map" instead of "hash_map" in several classes

WFS:

Utilities\OWS\stdafx.h
error C2338: <hash_map> is deprecated and will be REMOVED. Please use <unordered_map>. You can define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning
Solution:
-> remove include of no required <hash_map>

ArcSDE:

Providers\ArcSDE\Src\Provider\stdafx.h
error C2338: <hash_map> is deprecated and will be REMOVED. Please use <unordered_map>. You can define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning
Solution:
-> remove include of no required <hash_map>

SQLite:

Providers\sqlite\src\spatialindex\sltgeomutils.h
error C2039: 'min': is not a member of 'std'
Solution:
-> #include <algorithm>

providers\sqlite\src\provider\stringutil.h
error C2039: 'max': is not a member of 'std'
Solution:
-> #include <algorithm>


Best regards
Karsten
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20150819/d3dc2fd8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Providers_Shape.patch
Type: application/octet-stream
Size: 733 bytes
Desc: Providers_Shape.patch
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20150819/d3dc2fd8/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Providers_SDF.patch
Type: application/octet-stream
Size: 6749 bytes
Desc: Providers_SDF.patch
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20150819/d3dc2fd8/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Utilities_OWS_stdafx.h.patch
Type: application/octet-stream
Size: 438 bytes
Desc: Utilities_OWS_stdafx.h.patch
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20150819/d3dc2fd8/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Providers_ArcSDE_Src_Provider_stdafx.h.patch
Type: application/octet-stream
Size: 264 bytes
Desc: Providers_ArcSDE_Src_Provider_stdafx.h.patch
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20150819/d3dc2fd8/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Providers_SQLite.patch
Type: application/octet-stream
Size: 775 bytes
Desc: Providers_SQLite.patch
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20150819/d3dc2fd8/attachment-0004.obj>