[fdo-internals] Please review http://trac.osgeo.org/fdo/attachment/ticket/907/Fix907.patch

[Greg Boone]

Regarding....
if (m_nTotalProps == 0)
{
    m_nTotalProps = sqlite3_column_count(m_pStmt);
}

Why is the m_nTotalProps check for 0 needed? Why not directly call sqlite3_column_count(m_pStmt) ?  m_pStmt has just been reset in the statement above.

m_pStmt = m_connection->GetCachedParsedStatement(m_sql.Data());

Greg

From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Romica Dascalescu
Sent: Monday, May 11, 2015 11:28 AM
To: FDO Internals Mail List
Subject: Re: [fdo-internals] Please review http://trac.osgeo.org/fdo/attachment/ticket/907/Fix907.patch

+1

From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Christine Bao
Sent: Monday, May 11, 2015 6:00 AM
To: fdo-internals at lists.osgeo.org
Subject: [fdo-internals] Please review http://trac.osgeo.org/fdo/attachment/ticket/907/Fix907.patch

Hi all,

Please review http://trac.osgeo.org/fdo/attachment/ticket/907/Fix907.patch for fixing ticket http://trac.osgeo.org/fdo/ticket/907.

Thanks & regards,
Christine

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20150511/0c2c91ab/attachment.html>