[fdo-trac] #68: Array bounds checking in FdoSpatialUtility::GetExtents

FDO trac_fdo at osgeo.org
Wed May 2 14:15:13 EDT 2007


#68: Array bounds checking in FdoSpatialUtility::GetExtents
-------------------------+--------------------------------------------------
 Reporter:  gavincramer  |         Owner:  gavincramer
     Type:  defect       |        Status:  closed     
 Priority:  major        |     Milestone:  3.3.0      
Component:  FDO API      |       Version:  3.3.0      
 Severity:  3            |    Resolution:  fixed      
 Keywords:               |   External_id:             
-------------------------+--------------------------------------------------
Changes (by gavincramer):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 This adds array bounds checking to FdoSpatialUtility::GetExtents, to guard
 against malformed FGF values.

 An updated unit test now puts GetExtents through some challenging tests
 with bad
 input data.

 Some defects in FdoGeometry's existing array bounds checking were also
 found and
 fixed.

 Several tests using SDF and SHP were done to check that performance had
 negligible difference.

 Reviewed by:  Dan Stoica

 Log:

 Revision: 2752
 Author: gavincramer
 Date: 2:11:46 PM, Wednesday, May 02, 2007
 Message:
 Ticket #68 Array bounds checking in FdoSpatialUtility::GetExtents
 ----
 Modified : /trunk/Fdo/UnitTest/SpatialUtilityTest.cpp
 Modified : /trunk/Fdo/UnitTest/SpatialUtilityTest.h
 Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/GeometryFactory.cpp
 Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/LinearRing.cpp
 Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Util.cpp
 Modified : /trunk/Fdo/Unmanaged/Src/Geometry/Fgf/Util.h
 Modified : /trunk/Fdo/Unmanaged/Src/Spatial/SpatialUtility.cpp
 Modified :
 /trunk/Fdo/Unmanaged/Src/Spatial/SpatialUtilityGeometryExtents.cpp

-- 
Ticket URL: <http://trac.osgeo.org/fdo/ticket/68#comment:2>
FDO <http://fdo.osgeo.org/>
Feature Data Objects


More information about the fdo-trac mailing list