[fdo-trac] #807: SHP Provider: Multi-polygon geometry type is not exposed via GetGeometryComponentTypes()

FDO trac_fdo at osgeo.org
Mon Jan 16 13:18:55 EST 2012


#807: SHP Provider: Multi-polygon geometry type is not exposed via
GetGeometryComponentTypes()
-------------------------+--------------------------------------------------
   Reporter:  danstoica  |       Owner:  gregboone
       Type:  defect     |      Status:  new      
   Priority:  major      |   Milestone:  3.7.0    
  Component:  FDO API    |     Version:  3.7.0    
   Severity:  3          |    Keywords:           
External_id:             |  
-------------------------+--------------------------------------------------
 This is a legacy defect in
 ShpLpClassDefinition::ConvertPhysicalToLogicalGeometryProperty(), line
 #753:

             case ePolygonShape:
                 geomTypesDest[0] = FdoGeometryType_Polygon;
                 geomTypeCount=1;

 It should read instead:
             case ePolygonShape:
                 geomTypesDest[0] = FdoGeometryType_Polygon;
                 geomTypesDest[1] = FdoGeometryType_MultiPolygon;
                 geomTypeCount=2;

 (the same for other types of polygons)

 The rationale is that in fact SHP provider allows both Polygon and multi-
 Polygon features in the same file. Thus
 ShpGeometryCapabilities::GetGeometryComponentTypes() should return both
 Polygon and Multipolygon types, similar to the LineString.

-- 
Ticket URL: <http://trac.osgeo.org/fdo/ticket/807>
FDO <http://fdo.osgeo.org/>
Feature Data Objects


More information about the fdo-trac mailing list