[Fdo-trac] [fdo-trac] #934: Fix GenericRdbms unit test baseline
FDO
trac_fdo at osgeo.org
Sat Dec 2 08:29:30 PST 2017
#934: Fix GenericRdbms unit test baseline
------------------------------+------------------------
Reporter: jng | Owner: jng
Type: task | Status: assigned
Priority: major | Milestone:
Component: GenericRdbms API | Version:
Severity: 3 | Resolution:
Keywords: | External ID:
------------------------------+------------------------
Description changed by jng:
Old description:
> There's a whole series of backlogged patches against various
> GenericRdbms-based FDO providers (primarily for `OSGeo.PostgreSQL` and
> `OSGeo.SQLServerSpatial`) that I'd like to see applied, but before I do
> that, I want to make sure the GenericRdbms test suite baseline is all
> tests passing.
>
> Currently, this is not the case. With this environment:
>
> * SQL Server 2017 (on Linux)
> * MySQL 5.5
> * PostgreSQL 9.5/PostGIS 2.4
>
> We have the following failures:
>
> SQL Server:
> {{{
> !!!FAILURES!!!
> Test Results:
> Run: 274 Failures: 4 Errors: 0
>
> 1) test: SqlServerFdoApplySchemaTest.TestSchema (F) line: 1663
> Common\UnitTestUtil.cpp
> "Output file SQLServerSpatial_8759_apply_schema_test6_LPhF.xml differs
> from expected output file
> SQLServerSpatial_8759_apply_schema_test6_master.txt"
>
> 2) test: SqlServerFdoApplySchemaTest.TestOverrideErrors (F) line: 1663
> Common\UnitTestUtil.cpp
> "Output file
> SQLServerSpatial_8759_SQLServerSpatial_8759_apply_schema_overrides_err1SP.txt
> differs from expected output file
> apply_schema_overrides_err1SP_master.txt"
>
> 3) test: SqlServerFdoApplySchemaTest.TestNoMeta (F) line: 1663
> Common\UnitTestUtil.cpp
> "Output file
> SQLServerSpatial_8759_SQLServerSpatial_8759_apply_no_meta_err2.txt
> differs from expected output file apply_no_meta_err2_master.txt"
>
> 4) test: SqlServerSchemaMgrTests.testConfigError (F) line: 2051
> Common\SchemaMgrTests.cpp
> "pMessage && expectedMessage.ICompare(pMessage) == 0"
> }}}
>
> PostgreSQL:
> {{{
> !!!FAILURES!!!
> Test Results:
> Run: 131 Failures: 4 Errors: 0
>
> 1) test: PostGisFdoSpatialContextTest.testAxes (F) line: 190
> PostGis\PostGisFdoSpatialContextTest.cpp
> "wrong part of WKT removed, see log"
>
> 2) test: PostGisSchemaMgrTests.testGenDefault (F) line: 1663
> Common\UnitTestUtil.cpp
> "Output file PostGIS_8391_gen_default1.xml differs from expected output
> file PostGIS_8391_gen_default1_PostGIS_master.txt"
>
> 3) test: PostGisFdoApplySchemaTest.TestSchema (F) line: 1663
> Common\UnitTestUtil.cpp
> "Output file PostGIS_8391_apply_schema_test6_LPhF.xml differs from
> expected output file PostGIS_8391_apply_schema_test6_master.txt"
>
> 4) test: PostGisFdoApplySchemaTest.TestNoMeta (F) line: 1663
> Common\UnitTestUtil.cpp
> "Output file PostGIS_8391_apply_no_meta_test1.xml differs from expected
> output file PostGIS_8391_apply_no_meta_test1_master.xml"
> }}}
>
> MySQL:
> {{{
> !!!FAILURES!!!
> Test Results:
> Run: 244 Failures: 2 Errors: 1
>
> 1) test: MySqlFdoApplySchemaTest.TestSchema (F) line: 1223
> Common\UnitTestUtil.cpp
> "RDBMS: Duplicate entry 'aCxdATA-Acad' for key 'f_classdef_schnm_idx'
> "
>
> 2) test: MySqlFdoApplySchemaTest.TestOverrideErrors (F) line: 1663
> Common\UnitTestUtil.cpp
> "Output file MySql_10680_MySql_10680_apply_schema_overrides_err1.txt
> differs from expected output file apply_schema_overrides_err1_master.txt"
>
> 3) test: MySqlReaderTest.TestExceptionalCase (E)
> "caught unknown exception"
> }}}
>
> Most of these failures can be fixed by:
>
> 1. General: Removing whitespace around certain master text files that
> are not present in the generated result
> 2. General: Adding source file/line number to the `<error>` element of
> to `apply_schema_test6_master.txt`
> 3. MySQL: Un-expected exception due to running a SQL query using a table
> name in incorrect case.
New description:
There's a whole series of backlogged patches against various GenericRdbms-
based FDO providers (primarily for `OSGeo.PostgreSQL` and
`OSGeo.SQLServerSpatial`) that I'd like to see applied, but before I do
that, I want to make sure the GenericRdbms test suite baseline is all
tests passing.
Currently, this is not the case. With this environment:
* SQL Server 2017 (on Linux)
* MySQL 5.5
* PostgreSQL 9.5/PostGIS 2.4
We have the following failures:
SQL Server:
{{{
!!!FAILURES!!!
Test Results:
Run: 274 Failures: 4 Errors: 0
1) test: SqlServerFdoApplySchemaTest.TestSchema (F) line: 1663
Common\UnitTestUtil.cpp
"Output file SQLServerSpatial_8759_apply_schema_test6_LPhF.xml differs
from expected output file
SQLServerSpatial_8759_apply_schema_test6_master.txt"
2) test: SqlServerFdoApplySchemaTest.TestOverrideErrors (F) line: 1663
Common\UnitTestUtil.cpp
"Output file
SQLServerSpatial_8759_SQLServerSpatial_8759_apply_schema_overrides_err1SP.txt
differs from expected output file
apply_schema_overrides_err1SP_master.txt"
3) test: SqlServerFdoApplySchemaTest.TestNoMeta (F) line: 1663
Common\UnitTestUtil.cpp
"Output file
SQLServerSpatial_8759_SQLServerSpatial_8759_apply_no_meta_err2.txt differs
from expected output file apply_no_meta_err2_master.txt"
4) test: SqlServerSchemaMgrTests.testConfigError (F) line: 2051
Common\SchemaMgrTests.cpp
"pMessage && expectedMessage.ICompare(pMessage) == 0"
}}}
PostgreSQL:
{{{
!!!FAILURES!!!
Test Results:
Run: 131 Failures: 4 Errors: 0
1) test: PostGisFdoSpatialContextTest.testAxes (F) line: 190
PostGis\PostGisFdoSpatialContextTest.cpp
"wrong part of WKT removed, see log"
2) test: PostGisSchemaMgrTests.testGenDefault (F) line: 1663
Common\UnitTestUtil.cpp
"Output file PostGIS_8391_gen_default1.xml differs from expected output
file PostGIS_8391_gen_default1_PostGIS_master.txt"
3) test: PostGisFdoApplySchemaTest.TestSchema (F) line: 1663
Common\UnitTestUtil.cpp
"Output file PostGIS_8391_apply_schema_test6_LPhF.xml differs from
expected output file PostGIS_8391_apply_schema_test6_master.txt"
4) test: PostGisFdoApplySchemaTest.TestNoMeta (F) line: 1663
Common\UnitTestUtil.cpp
"Output file PostGIS_8391_apply_no_meta_test1.xml differs from expected
output file PostGIS_8391_apply_no_meta_test1_master.xml"
}}}
MySQL:
{{{
!!!FAILURES!!!
Test Results:
Run: 244 Failures: 2 Errors: 1
1) test: MySqlFdoApplySchemaTest.TestSchema (F) line: 1223
Common\UnitTestUtil.cpp
"RDBMS: Duplicate entry 'aCxdATA-Acad' for key 'f_classdef_schnm_idx'
"
2) test: MySqlFdoApplySchemaTest.TestOverrideErrors (F) line: 1663
Common\UnitTestUtil.cpp
"Output file MySql_10680_MySql_10680_apply_schema_overrides_err1.txt
differs from expected output file apply_schema_overrides_err1_master.txt"
3) test: MySqlReaderTest.TestExceptionalCase (E)
"caught unknown exception"
}}}
Most of these failures can be fixed by:
1. General: Removing whitespace around certain master text files that are
not present in the generated result
2. General: Adding source file/line number to the `<error>` element of to
`apply_schema_test6_master.txt`
3. MySQL: Un-expected exception due to running a SQL query using a table
name in incorrect case.
4. SqlServerSchemaMgrTests.testConfigError: Load an alternative
configuration document for the test case that does not use OracleProvider
schema mappings.
--
--
Ticket URL: <https://trac.osgeo.org/fdo/ticket/934#comment:1>
FDO <http://fdo.osgeo.org/>
Feature Data Objects
More information about the fdo-trac
mailing list