[fdo][FDO318][Modified] Fixed several defects; added new TestCommon static lib

[Pierre Dalcourt]

You can view the artifact detail at the following URL:

    https://fdo.osgeo.org/servlets/Scarab/id/FDO318

Type:
Defect

Artifact ID:
FDO318 (Fixed several defects; added new TestCommon static lib)

Modified by:
Pierre Dalcourt
pierredalcourt (pierre.dalcourt at autodesk.com)

The following modifications were made to this artifact:
---------------------------------------------------------------------

-- Summary changed:
Old value:
Fixed defects 815921, 815922, 815926, 814445, 817232; added new TestCommon static lib (ported from Reliant R071-PD1)
New value:
Fixed several defects; added new TestCommon static lib
-- Description set to new value:
Old value:
Fixed defects 815921 "MySQL: Regression: Computed properties no longer function in SelectFeatures"
          and 815922 "SqlServer: Regression: Computed properties no longer function in SelectFeatures" :

	- The method FdoRdbmsFeatureReader::FilterClassDefinition() was accessing member variables mColCount/mColList before they were initialized;
	calling GetPropertyCount() first fixes this problem by populating these members.


Fixed defects 815926 "MySQL: Regression: SelectFeatures on MySQL allows computed field alias to match feature property name yeilding duplicates"
          and 814445 "SqLServer: Regression: SelectFeatures on SQLServer allows computed field alias to match feature property name yeilding duplicates" :

	- GdbiQueryResult::GdbiQueryResult() was silently ignoring when the underlying RDBMS returned 2 columns with same name, now throws exception instead
	- updated FdoIdentifierCollection to verify for entries with duplicate GetText() values, to prevent users from selecting
		multiple identifiers that have the same name.
	- fixed: FdoSmPhRdMqlColumnReader::MakeQueryReader() create a sql query with TWO size columns, one gets thrown away by
		GdbiQueryResult::GdbiQueryResult() because of duplicate name (Derrick's 'memory leak' fix)


Fixed defect 817232 "Oracle: Select FeatureProperty and Computed property results in computed property appearing twice":

	- fixed: oracle\src\dbgql\gid\ds_.c's dname_and_tbl_cmp() wasn't distinguishing between non-computed properties and computed properties
	when they both referred to the same underlying property.


Added a new TestCommon static library, which is analogous to FdoCommon except contains unit-test-specific code (generic tests and utilities)
and thus is only linked in by unit test executables.  Moved failgeneric () utility to this library.

Enlarged the Oracle/GenericRDBMS unit test error message buffer; instead of cropping error messages at 132 chars it now outputs up to 512 chars.

New value:
Fixed defects "MySQL: Regression: Computed properties no longer function in SelectFeatures"
          and "SqlServer: Regression: Computed properties no longer function in SelectFeatures" :

	- The method FdoRdbmsFeatureReader::FilterClassDefinition() was accessing member variables mColCount/mColList before they were initialized;
	calling GetPropertyCount() first fixes this problem by populating these members.


Fixed defects "MySQL: Regression: SelectFeatures on MySQL allows computed field alias to match feature property name yeilding duplicates"
          and "SqLServer: Regression: SelectFeatures on SQLServer allows computed field alias to match feature property name yeilding duplicates" :

	- GdbiQueryResult::GdbiQueryResult() was silently ignoring when the underlying RDBMS returned 2 columns with same name, now throws exception instead
	- updated FdoIdentifierCollection to verify for entries with duplicate GetText() values, to prevent users from selecting
		multiple identifiers that have the same name.
	- fixed: FdoSmPhRdMqlColumnReader::MakeQueryReader() create a sql query with TWO size columns, one gets thrown away by
		GdbiQueryResult::GdbiQueryResult() because of duplicate name (Derrick's 'memory leak' fix)


Fixed defect "Oracle: Select FeatureProperty and Computed property results in computed property appearing twice":

	- fixed: oracle\src\dbgql\gid\ds_.c's dname_and_tbl_cmp() wasn't distinguishing between non-computed properties and computed properties
	when they both referred to the same underlying property.


Added a new TestCommon static library, which is analogous to FdoCommon except contains unit-test-specific code (generic tests and utilities)
and thus is only linked in by unit test executables.  Moved failgeneric () utility to this library.

Enlarged the Oracle/GenericRDBMS unit test error message buffer; instead of cropping error messages at 132 chars it now outputs up to 512 chars.




---------------------------------------------------------------------
This message was automatically generated by Project Tracker.