[fusion-dev] [Code Review]http://trac.osgeo.org/fusion/attachment/ticket/344/patch344.patch

Paul Spencer pspencer at dmsolutions.ca
Fri Dec 4 06:18:32 EST 2009


I'm much happier with this :)  Thanks Arthur, the code looks okay and if it is working, please go ahead and submit it

Cheers

Paul

On 2009-12-03, at 10:21 PM, Arthur Liu wrote:

> Thanks Paul, I've updated the code according to your suggestion. Would you please review it again?
> 
> Thanks,
> Arthur
> 
> -----Original Message-----
> From: Paul Spencer [mailto:pspencer at dmsolutions.ca] 
> Sent: Friday, December 04, 2009 12:07 AM
> To: Arthur Liu
> Cc: fusion-dev at lists.osgeo.org
> Subject: Re: [fusion-dev] [Code Review]http://trac.osgeo.org/fusion/attachment/ticket/344/patch344.patch
> 
> I'm not keen on changing OpenLayers code without a patch going to OpenLayers, otherwise this will just break the next time we update OpenLayers.  Is there not some way to use the OpenLayers API to modify the zIndex of the redline layer to achieve the same effect?
> 
> Cheers
> 
> Paul
> 
> On 2009-12-03, at 4:01 AM, Arthur Liu wrote:
> 
>> Hi all,
>> 
>> Would you please review http://trac.osgeo.org/fusion/attachment/ticket/344/patch344.patchfor fixing http://trac.osgeo.org/fusion/ticket/344 Object drawn by Redline with consumer map didn't display until Zoom map?
>> 
>> [Description]
>> 1. Open one flexible web layout with commercial layers.
>> 2. Redline -> Draw point.
>> Results:
>> Nothing shown.
>> Zoom in or out, the point drawn displayed.
>> Object drawn by Spatial Query has the same issue.
>> 
>> [Resolution]
>> 1. In redline.js, added the evt.feature.layer.redraw() to redraw the redline layer after feature added.
>> 2. In OpenLayers.js, updated setLayerZIndex method to make sure redline layer can display at the top of map layers, regardless there are more than one overlay layers.
>> 
>> Thanks,
>> Arthur
>> _______________________________________________
>> fusion-dev mailing list
>> fusion-dev at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/fusion-dev
> 
> 
> __________________________________________
> 
>   Paul Spencer
>   Chief Technology Officer
>   DM Solutions Group Inc
>   http://research.dmsolutions.ca/
> 


__________________________________________

   Paul Spencer
   Chief Technology Officer
   DM Solutions Group Inc
   http://research.dmsolutions.ca/



More information about the fusion-dev mailing list