[fusion-dev] RE: FeatureReader not being closed in MapGuide Query.php?

[Mike Adair]

Yes a ticket would be good to keep track.  I thought we found all those 
but it appears not...

Mike

Jason Birch wrote:
> Should I be entering tickets for these?  I didn't expect to find so many that I had questions about.
>
> Another in: 
>  trunk/widgets/SelectWithin/SelectWithin.php
>
> On line 109, it appears that an MgFeatureReader called $featureReader is opened but not closed.
>
> Jason
>
> -----Original Message-----
> From: fusion-dev-bounces at lists.osgeo.org [mailto:fusion-dev-bounces at lists.osgeo.org] On Behalf Of Jason Birch
> Sent: March-23-09 1:23 PM
> To: fusion-dev at lists.osgeo.org
> Subject: [fusion-dev] RE: FeatureReader not being closed in MapGuide Query.php?
>
> Similarly...
>
> It looks to me that in the file
>   trunk/widgets/Search/Search.php
>
> The MgFeatureReader called $features is only closed in the exception handling logic, not in the normal code stream.
>
> Jason
>
> -----Original Message-----
> From: Jason Birch
> Sent: March-23-09 1:14 PM
> To: fusion-dev at lists.osgeo.org
> Subject: [fusion-dev] FeatureReader not being closed in MapGuide Query.php?
>
> Could someone check my logic on this one please?
>
> I believe that for:
>   trunk/layers/MapGuide/php/Query.php
>
> There is an MgFeatureReader being opened on line 199 which is being closed on line 268.
>
> However, on line 261, I believe that a second MgFeatureReader is being opened using the same variable name without closing the initial MgFeatureReader first, and that this second reader is never closed.
>
> Thoughts?  Time for an eye exam?
>
> Thanks,
> Jason
> _______________________________________________
> fusion-dev mailing list
> fusion-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/fusion-dev
> _______________________________________________
> fusion-dev mailing list
> fusion-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/fusion-dev
>
>   

-- 
   Michael Adair
   Senior Software Architect
   DM Solutions Group Inc.

   Office: (613) 565-5056 x26
   madair at dmsolutions.ca
   http://www.dmsolutions.ca
   http://research.dmsolutions.ca