[fusion-dev] Raster layer's icon displayed as disabled icon in MapGuide

[Arthur Liu]

Hi Mike,

Thank you for the test,  I have updated the legend.js at http://trac.osgeo.org/fusion/attachment/ticket/306/RasterLayerIconInLegend.2.patch
Because MapGuide raster layer doesn't contain the style so the else block will not be executed. So I move it out of the else block. Would you please confirm that?

Thanks,
Arthur 

-----Original Message-----
From: Mike Adair [mailto:madair at dmsolutions.ca] 
Sent: Friday, February 05, 2010 2:12 AM
To: Arthur Liu
Cc: fusion-dev at lists.osgeo.org
Subject: Re: [fusion-dev] Raster layer's icon displayed as disabled icon in MapGuide

Arthur,

I tested it and it breaks the Legend for MapServer, which uses the 
style.iconOpt property to set the legend icon from a sprite. (It does 
set a raster layer icon properly though).

I think you need to re-do the logic in the if statements, probably going 
back to something like the original:
if (!style) {
} else {
if (layerType...)
}
and put back in the style.iconOpt.url logic.

Mike



Arthur Liu wrote:
>
> Hi all,
>
> This review lasts such a long time but I still got no response, I have 
> updated the patch at 
> http://trac.osgeo.org/fusion/attachment/ticket/306/RasterLayerIconInLegend.patch 
> and could someone test it on MapServer please?
>
> Regards,
>
> Arthur
>
> * *
>
> * *
>
> *From:* fusion-dev-bounces at lists.osgeo.org 
> [mailto:fusion-dev-bounces at lists.osgeo.org] *On Behalf Of *Arthur Liu
> *Sent:* Monday, November 30, 2009 2:40 PM
> *To:* fusion-dev at lists.osgeo.org
> *Subject:* RE: [fusion-dev] Creating Vector Points on the Map from 
> Task Pane
>
> Hi all,
>
> Would you please review 
> http://trac.osgeo.org/fusion/attachment/ticket/306/Patch306.patch for 
> fixing http://trac.osgeo.org/fusion/ticket/306 Legend panel is empty 
> with Raster/WMS data source?
>
> Comments: In the original implementation, for raster layer which 
> doesn't contain any styles, the legend icon is set to 
> imgDisabledLayerIcon, which should be imgLayerRasterIcon actually.
>
> Thanks,
>
> Arthur
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> fusion-dev mailing list
> fusion-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/fusion-dev
>   

-- 
   Michael Adair
   Senior Software Architect
   DM Solutions Group Inc.

   Office: (613) 565-5056 x26
   madair at dmsolutions.ca
   http://www.dmsolutions.ca
   http://research.dmsolutions.ca