[fusion-trac] #523: Fusion.SimpleSelectionObject using a global variable

[Fusion]

#523: Fusion.SimpleSelectionObject using a global variable
------------------------+---------------------------------------------------
   Reporter:  mooman    |       Owner:  madair
       Type:  defect    |      Status:  new   
   Priority:  P2        |   Milestone:  Future
  Component:  MapGuide  |     Version:  SVN   
   Severity:  Minor     |    Keywords:        
External_id:            |       State:  New   
    Browser:  All       |          Os:  All   
------------------------+---------------------------------------------------
 The initialize method in class Fusion.SimpleSelectionObject uses the
 variable "o" which is set via eval("o=" + r.responseText) outside the
 class as a global variable. It also uses the parameter that is passed in
 (featureInfoResponse). This is inconsistent and makes that class confusing
 to use. Not to mention potential bugs.

 The fix is simple. Replace "o" with "featureInfoResponse".

 See this line:
 http://trac.osgeo.org/fusion/browser/trunk/layers/MapGuide/MapGuide.js#L1432

 This bug still exists in the trunk.

 Thank you!

-- 
Ticket URL: <http://trac.osgeo.org/fusion/ticket/523>
Fusion <http://trac.osgeo.org/fusion>
Fusion is a web-mapping application development framework for MapServer and MapGuide OS.