From trac_fusion at osgeo.org Mon Oct 1 06:44:25 2018 From: trac_fusion at osgeo.org (Fusion) Date: Mon, 01 Oct 2018 13:44:25 -0000 Subject: [fusion-trac] #664: Re-instate Google Maps script appending client-side Message-ID: <043.533866f40b6aa094c8cf9cfc8b112081@osgeo.org> #664: Re-instate Google Maps script appending client-side ----------------------------+------------------------ Reporter: jng | Owner: jng Type: defect | Status: assigned Priority: P2 | Milestone: Future Component: Widgets | Version: 2.0 Severity: Major | Keywords: Browser: All | External ID: Operating System: All | state: New ----------------------------+------------------------ Although the unified entry point work removed loading Google Maps script tags client-side, upon second thought: It is possible to "safely" load Google Maps on the client-side (don't `document.write` the script tags, rather `document.createElement` the required script tags just like we do for the widgets). This way, we don't need to force a breaking migration change to the new unified entry point and existing users can still remain on the `index.html` entry point. -- Ticket URL: Fusion Fusion is a web-mapping application development framework for MapServer and MapGuide OS. From trac_fusion at osgeo.org Mon Oct 1 06:49:21 2018 From: trac_fusion at osgeo.org (Fusion) Date: Mon, 01 Oct 2018 13:49:21 -0000 Subject: [fusion-trac] #664: Re-instate Google Maps script appending client-side In-Reply-To: <043.533866f40b6aa094c8cf9cfc8b112081@osgeo.org> References: <043.533866f40b6aa094c8cf9cfc8b112081@osgeo.org> Message-ID: <058.7ffabfe9abda8eead6395f591b40c6d0@osgeo.org> #664: Re-instate Google Maps script appending client-side -----------------------+--------------------------- Reporter: jng | Owner: jng Type: defect | Status: closed Priority: P2 | Milestone: Future Component: Widgets | Version: 2.0 Severity: Major | Resolution: fixed Keywords: | Browser: All External ID: | Operating System: All state: New | -----------------------+--------------------------- Changes (by jng): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"3047" 3047]: {{{ #!CommitTicketReference repository="" revision="3047" Re-instate client-side Google Maps script loading. It slipped my mind when I removed the client-side loading that we can actually do this in a "safe" manner. We just document.createElement() the script tag instead of document.write()'ing it. This is what we're doing for the widget scripts. As part of this change, several synchronous XHR requests we were making have been converted to async as well. Fixes #664 }}} -- Ticket URL: Fusion Fusion is a web-mapping application development framework for MapServer and MapGuide OS. From trac_fusion at osgeo.org Mon Oct 1 06:57:45 2018 From: trac_fusion at osgeo.org (Fusion) Date: Mon, 01 Oct 2018 13:57:45 -0000 Subject: [fusion-trac] #664: Re-instate Google Maps script appending client-side In-Reply-To: <043.533866f40b6aa094c8cf9cfc8b112081@osgeo.org> References: <043.533866f40b6aa094c8cf9cfc8b112081@osgeo.org> Message-ID: <058.510e41f347ab4c70108e3ade9bc4f649@osgeo.org> #664: Re-instate Google Maps script appending client-side -----------------------+--------------------------- Reporter: jng | Owner: jng Type: defect | Status: closed Priority: P2 | Milestone: Future Component: Widgets | Version: 2.0 Severity: Major | Resolution: fixed Keywords: | Browser: All External ID: | Operating System: All state: New | -----------------------+--------------------------- Comment (by jng): In [changeset:"3048" 3048]: {{{ #!CommitTicketReference repository="" revision="3048" Merged revision(s) 3047 from trunk: Re-instate client-side Google Maps script loading. It slipped my mind when I removed the client-side loading that we can actually do this in a "safe" manner. We just document.createElement() the script tag instead of document.write()'ing it. This is what we're doing for the widget scripts. As part of this change, several synchronous XHR requests we were making have been converted to async as well. Fixes #664 ........ }}} -- Ticket URL: Fusion Fusion is a web-mapping application development framework for MapServer and MapGuide OS.