[gdal-dev] OGRSpatialReference::IsSame

[Frank Warmerdam]

Ben Discoe wrote:
> Either i am quite confused, or there is a rather prominent bug in
> OGRSpatialReference::IsSame() The following test:
> 
> if( EQUAL(GetRoot()->GetValue(),poOtherSRS->GetRoot()->GetValue()) )
> return FALSE;
> 
> ... returns FALSE if the two root node values *are* the same, rather than if
> they *aren't*. So there is a false negative result for identical
> SpatialReferences. I think the test should say "if( !EQUAL(" ...

Ben,

You are right. I have commited a few fixes to the IsSame() method; however,
there are still limits to how far you should trust this method.

Best regards,
-- 
---------------------------------------+--------------------------------------
I set the clouds in motion - turn up | Frank Warmerdam, warmerdam at p...
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush | Geospatial Programmer for Rent