[gdal-dev] Code submission for NITF driver

Even Rouault even.rouault at mines-paris.org
Tue Mar 2 16:23:21 EST 2010


I'll try reviewing and commiting your changes. From a first look, they are 
quite substantial/non trivial. Am I wrong if I say they belong more to the 
enhancement category than to the bugfix one ? (I assume writing TEXT and CGM 
segments, and the interaction with writing multiple images, is not a common 
use case of the NITF driver)

I'll need your testing to check that the changes that will be commited still 
work with third-party software and validation tools (not using GDAL I mean). 
I anticipate a few refactoring changes, for example as there seems to be 
several instances of code that reads NUMI, NUMS and NUMT records.  I think 
I'll avoid the use of the CGM_%d_SIZE hidden option to be passed to 
NITFCreate(), but let NITFWriteCGMSegments() patch the necessary bytes in the 
header instead.

Best regards,


> Chiou, Kevin wrote:
> > Hi,
> >   I just wonder what the process is for submitting code to GDAL.
> >   I was working on a NITF editing tool using GDAL driver.  I made some
> > modification to the NITF driver including adding a CGM writing feature
> > and fixed some data validation bugs.  I submitted a ticket a couple
> > weeks ago, but nothing happened since then.  Is there something else I
> > should do or are there someone I should get in touch with?
> >
> > Ticket opened: _http://trac.osgeo.org/gdal/ticket/3376_
> Kevin,
> I appreciate the submission but it seems neither Even nor I have had
> time to review and integrate your changes.  The NITF driver is fragile
> and complex enough I hesitate to ask Chaitanya or anyone else to try
> commit the changes.
> I hope one of us will get to it reasonably soon, though I'm pretty sure
> there are significant NITF driver contributions still sitting in trac
> unintegrated from other contributors from years ago.
> Best regards,

More information about the gdal-dev mailing list