[gdal-dev] RFC 61: Call for vote on adoption

[Ari Jolma]

12.02.2016, 12:43, Even Rouault kirjoitti:
>> There are still a couple of fixme's in the code (shape2ogr.cpp), writing
>> a shape should take into account the requested coordinate combination
>> and whether to skip Ms or write them as "no data" (value < 1038
>> according to the doc).
> -10^38

copy paste error from pdf :)

>
>> I changed the code for OGRFeature::SetGeomFieldDirectly to set or unset
>> the geometry M or Z coordinates depending on the geometry field type of
>> the feature. That's somewhat bold but the way I did it at least did not
>> break anything in the tests.
> Agreed it is a non trivial change. But it does break things. Crashes in the
> CSW driver for example :
> https://travis-ci.org/rouault/gdal_coverage/builds/108752731 .
> And other non crashing failures.
> Perhaps do this dimension harmonization not in SetGeomFieldDirectly() but in a
> helper function and call it in the shapefile driver if you need it ?
> We could also try to fix drivers/tests, but there may be cases where drivers
> cannot declare a consistant coordinate dimensionnality because they have a mix
> of {Geom} and {Geom}Z features

ok, I should perhaps set up a better local test environment.

I now limit the dimension harmonization to the shape driver @33440.

Ari