[gdal-dev] GDAL/OGR 2.0.2 RC1 Available for Review

[Jürgen E. Fischer]

Hi Even,

On Fri, 22. Jan 2016 at 12:14:32 +0100, Even Rouault wrote:
> ... and now a GDAL/OGR 2.0.2 release candidate. Please review and test.

I added it to OSGeo4W as experimental.

I found one problem that causes ogr2ogr to break when inserting duplicate data
into postgres although -skipfailures is used.

Following patch fixes that for me (but I'm not sure if it affects other cases):

diff -ur ../orig/gdal-2.0.2/apps/ogr2ogr.cpp ./apps/ogr2ogr.cpp
--- ../orig/gdal-2.0.2/apps/ogr2ogr.cpp 2016-01-22 11:51:09.000000000 +0100
+++ ./apps/ogr2ogr.cpp  2016-01-23 00:43:21.392717800 +0100
@@ -4049,6 +4049,17 @@
             {
                 CPLDebug( "OGR2OGR", "Unable to write feature " CPL_FRMT_GIB " into layer %s.\n",
                            poFeature->GetFID(), poSrcLayer->GetName() );
+
+                if( bLayerTransaction )
+                {
+                    poDstLayer->RollbackTransaction();
+                    poDstLayer->StartTransaction();
+                }
+                else
+                {
+                    poODS->RollbackTransaction();
+                    poODS->StartTransaction(bForceTransaction);
+                }
             }
 
 end_loop:


Jürgen

-- 
Jürgen E. Fischer           norBIT GmbH             Tel. +49-4931-918175-31
Dipl.-Inf. (FH)             Rheinstraße 13          Fax. +49-4931-918175-50
Software Engineer           D-26506 Norden             http://www.norbit.de
QGIS release manager (PSC)  Germany                    IRC: jef on FreeNode                         
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 827 bytes
Desc: Digital signature
URL: <http://lists.osgeo.org/pipermail/gdal-dev/attachments/20160123/e079ddd1/attachment.sig>