[gdal-dev] GDAL 2.2.0beta1 and old poppler libraries

[Even Rouault]

On jeudi 20 avril 2017 12:54:08 CEST Andrew C Aitchison wrote:
> On Sun, 16 Apr 2017, Even Rouault wrote:
> > On dimanche 16 avril 2017 20:31:09 CEST Andrew C Aitchison wrote:
> >> GDAL 2.2.0 beta1
> >> Scientific Linux 6 (= CentOS6 =  Red Hat EL 6).
> >> g++ 4.9.2 and g++ 5.3.1
> >> 
> >> gdal-2.2.0/frmts/pdf/pdfdataset.cpp does not compile on my
> >> Scientific Linux 6 (= CentOS6 =  Red Hat EL 6) machine.
> >> 
> >> pdfio.h lines 87-90:
> >>     private:
> >>          /* Added in poppler 0.15.0 */
> >>          virtual GBool hasGetChars() override;
> >>          virtual int getChars(int nChars, Guchar *buffer) override;
> > 
> > You can just remove the override qualifier in the above methods.
> > Supporting properly this old version could be done but would be quite
> > tedious.
> 
> I found an existing define which is true for poppler >= 0.16.
> And have written a patch which leaves the override qualifier for
> newer poppler libraries but disables it for very old ones.
> Somewhere around 0.15 or 0.16 it will incorrectly remove the override
> qualifier, but the code will still compile correctly.

Thanks Andrew. Your patch is reasonable. I've just committed it.

Even

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/gdal-dev/attachments/20170420/50f5f27d/attachment.html>