[gdal-dev] #include tiffio.h in gtiff/libgeotiff/

[Even Rouault]

On jeudi 12 avril 2018 09:56:35 CEST Ari Jolma wrote:
> The file frmts/gtiff/libgeotiff/xtiffio.h #include's "tiffio.h", which
> is in frmts/gtiff/libtiff. However, when compiling in this directory
> frmts/gtiff/libtiff is not included.

I presume the libtiff.so must be present on the system, but not the TIFF 
headers. Likely development package of libtiff missing.
GDAL's configure apparently only check the presence of the .so but doens't 
check that the header is available.
Internal tiffio.h is included by internal libgeotiff if GDAL detects use of 
internal libtiff (TIFF_SETTING=internal in GDALmake.opt)
But it wouldn't be correct for the internal libgeotiff to include the internal 
tiffio.h and linking against external libgeotiff.

So the immediate fix is make sure libtiff headers are present on the system 
(or explicitly select internal libtiff in ./configure)
And an improvement in configure.ac would be also welcome to check that the 
headers of external libtiff are available.

Even

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com