[gdal-dev] C4251 warnings in VS2017

[Even Rouault]

On mardi 11 juin 2019 16:37:46 CEST Mateusz Loskot wrote:
> On Tue, 11 Jun 2019 at 16:20, Michel Dastous <Michel.Dastous at bentley.com> 
wrote:
> > Im asking because ticket #4099 was closed saying it should no longer be an
> > issue with MSVC2015, so I was expecting it to be fixed in VS2017.
> Right, I missed that one.

I think we would accept a pull request that would change public header files 
that trigger that warning to essentially do (untested !)

#ifdef _MSC_VER
#pragma warning( push )
#pragma warning( disable : 4251 ) // class 'foo' needs to have dll-interface
#endif

...

#ifdef _MSC_VER
#pragma warning( pop )
#endif

Even

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com