[gdal-dev] shapelib 1.6.1RC2 available (was Re: shapelib 1.6.1RC1 available)

[Greg Troxel]

(I'm building with autoconf.)

1) It builds fine on NetBSD 10 amd64, using an old pkgsrc workaround/?? to
explicitly build only the libs (that may well be no longer relevant):

  # \todo Explain why we don't install what shapelib installs.
  # \todo Perhaps file a bug upstream that the bin programs are not namespaced.
  BUILD_TARGET=          libshp.la
  INSTALL_TARGET=                install-libLTLIBRARIES install-libshp_la_includeHEADERS install-pkgconfigDATA

2) The tests all fail because they have #! lines with /bin/bash.  While it
could document a dependency on bash, and then find bash with configure
and substitute it, that all seems quite avoidable as I don't see
anything in the test scripts that really need non-POSIX sh features.

With the bash problem worked around, most tests pass, except

  FAIL: tests/shpproj.sh
  ======================

  ../test-driver: ./tests/shpproj.sh: not found
  FAIL tests/shpproj.sh (exit status: 127)

and I don't see that in the tarball, so I'm guessing that isn't a
problem only I am seeing.

shapelib doesn't depend on proj, so perhaps there needs to be
documentation of tests dependencies?

3) pkgsrc used to have this marked MAKE_JOBS_SAFE=no meaning "don't
allow -jN to make", without a comment.  I don't see why this would be
true so I'm going to remove that, but am mentioning it in case someone
else thinks it is needed.

4) I undid the kludge in 1, and I get a failure to build, because make
fires the rule for one of the programs first, and libshp.la isn't built
yet.  Running again with gmake instead, it builds.  So there's something
wrong, but I suspect it's wiser to work around this by documenting that
GNU Make is required.

5) There are a surprisingly large number of programs in bin.  The pkgsrc
package didn't used to install them, but they look like that likely
won't conflict with other pacakges..  Do you think users of shapelib
expect all of these to be installed?

  bin/Shape_PointInPoly
  bin/csv2shp
  bin/dbfadd
  bin/dbfcat
  bin/dbfcreate
  bin/dbfdump
  bin/dbfinfo
  bin/shpadd
  bin/shpcat
  bin/shpcentrd
  bin/shpcreate
  bin/shpdata
  bin/shpdump
  bin/shpdxf
  bin/shpfix
  bin/shpinfo
  bin/shprewind
  bin/shpsort
  bin/shptreedump
  bin/shputils
  bin/shpwkb