[gdal-dev] Some Tests fail in Actions tab of my branch

[Abel Pau]

I think there’ll be no problem about changing to MIT the code we want to add to GDAL.
I just copied it from other place like ogr\ogrsf_frmts\mem\ogrmemlayer.cpp

Or this is specified somewhere else I don’t know?

Thanks for the branch advise. I’ll started a long time ago. I am learning by the time. Thanks :)

De: Even Rouault <even.rouault at spatialys.com>
Enviado el: dimecres, 21 de febrer de 2024 12:49
Para: Abel Pau <a.pau at creaf.uab.cat>; gdal-dev at lists.osgeo.org
Asunto: Re: [gdal-dev] Some Tests fail in Actions tab of my branch


I've skimmed *very quickly* over the code (by the way you should create a dedicated git branch and not hack into the master branch. cf https://gdal.org/development/dev_practices.html#working-with-a-feature-branch), so in no means a code review,  but I noticed there's a LGPL license file. This is going to be a blocker if you want to submit your code for upstream GDAL inclusion as we can't accept LGPL in the core library. If the code subject to LGPL is under your control, please relicense to MIT.

Even
Le 21/02/2024 à 12:36, Abel Pau a écrit :
Ah ok!! Thanks Even.
I’ll review that, then! I didn’t though in that way

De: Even Rouault <even.rouault at spatialys.com><mailto:even.rouault at spatialys.com>
Enviado el: dimecres, 21 de febrer de 2024 12:34
Para: Abel Pau <a.pau at creaf.uab.cat><mailto:a.pau at creaf.uab.cat>; gdal-dev at lists.osgeo.org<mailto:gdal-dev at lists.osgeo.org>
Asunto: Re: [gdal-dev] Some Tests fail in Actions tab of my branch


Abel,
Hi,
lately I’ve been solving some issues in my code to finally do a pull request of the MiraMon vector driver.

There some things about test in the action I don’t understand. I haven’t commit any test yet. So I assume it’s not my fault.
Anyone knows why some of them are failing?

You can see in the logs that it fails on autotest/ogr/ogr_basic_test.py::test_ogr_basic_10, and this test runs "test_ogrsf -all_drivers". As the name suggests, this test does some very minimal testing of all OGR drivers. I assume it must crash when running on the Miramon driver
Even

--

http://www.spatialys.com

My software is free, but my time generally not.

--

http://www.spatialys.com

My software is free, but my time generally not.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/gdal-dev/attachments/20240221/42d911e7/attachment-0001.htm>