What's the process by which I can submit that change, or request to have someone with commit access add it? Thanks.<div><br></div><div><br><br><div class="gmail_quote">On Fri, Jul 30, 2010 at 9:54 AM, Frank Warmerdam <span dir="ltr"><<a href="mailto:warmerdam@pobox.com">warmerdam@pobox.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div><div></div><div class="h5">Joel Odom wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I'm encountering an issue where once I've set an attribute filter on an ESRI personal geodatabase, I cannot clear that filter. If I pass NULL to SetAttributeFilter, the filter is internally set to "", which makes future queries return zero results instead of all rows. Examining the personal geodatabase driver code, I find:<br>
<br>
OGRErr OGRPGeoTableLayer::SetAttributeFilter( const char *pszQuery )<br>
{<br>
if( (pszQuery == NULL && this->pszQuery == NULL)<br>
|| (pszQuery != NULL && this->pszQuery != NULL && EQUAL(pszQuery,this->pszQuery)) )<br>
return OGRERR_NONE;<br>
<br>
CPLFree( this->pszQuery );<br>
this->pszQuery = CPLStrdup( pszQuery );<br>
<br>
ClearStatement();<br>
<br>
return OGRERR_NONE;<br>
}<br>
<br>
Around the line, "this->pszQuery = CPLStrdup( pszQuery );" should there be an additional bit of logic that sets this->pszQuery to NULL if pszQuery is NULL? I've searched this mailing list and find no reference to this. Is there a possible work around? Thanks.<br>
</blockquote>
<br></div></div>
Joel,<br>
<br>
Yes, I think you are right. I imagine this:<br>
<br>
this->pszQuery = CPLStrdup( pszQuery );<br>
<br>
should be replaced with:<br>
if( pszQuery )<br>
this->pszQuery = CPLStrdup(pszQuery);<br>
else<br>
this->pszQuery = NULL;<br>
<br>
Could you file a ticket on this issue at <a href="http://trac.osgeo.org/gdal" target="_blank">http://trac.osgeo.org/gdal</a>?<div><div></div><div class="h5"><br>
<br>
Best regards,<br>
-- <br>
---------------------------------------+--------------------------------------<br>
I set the clouds in motion - turn up | Frank Warmerdam, <a href="mailto:warmerdam@pobox.com" target="_blank">warmerdam@pobox.com</a><br>
light and sound - activate the windows | <a href="http://pobox.com/~warmerdam" target="_blank">http://pobox.com/~warmerdam</a><br>
and watch the world go round - Rush | Geospatial Programmer for Rent<br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><a href="http://www.operationliberate.com/">http://www.operationliberate.com/</a><br>
</div>