<br><font size=2 face="sans-serif">Ludovic,</font>
<br><font size=2 face="sans-serif"> This
is excellent news and again any improvement to the original code is welcome.
I actually am in the process of how to map the projection information for
a potential ISIS3 writer. I also have a Python PDS label creation routine
that I was thinking about pushing into library properly (instead of just
using a Python script). It would also make sense to merge the PDS and ISIS2
code set however there are subtitle differences in both formats that we
must be careful of.</font>
<br>
<br><font size=2 face="sans-serif">Before we can incorporate your changes
into GDAL, I would like to see projection export support implemented also.
The main reason for these readers was to help propagate the projection,
so I would want to see this working both directions. I will see where it
stands and if I can help. I'm not sure how to implement "create_copy"
so we might need help from the GDAL team.</font>
<br>
<br><font size=2 face="sans-serif">Let me check out your patch and test
some images. If all looks good we ask the GDAL team to also help incorporate
your patch. Also there is another PDS fix that needs to be incorporated.
Maybe you might have time to see if it would be a quick fix since you have
been working wit the code recently (please see issue below). If you don't
have time please let me know. I am also curious how you managed to support
ISIS2 side planes? This capability was removed from ISIS3 due to lack of
use and complexity. </font>
<br>
<br><font size=2 face="sans-serif">Thanks again for your willingness to
share your improvements. Just out of curiosity - what facility are you
working with?</font>
<br>
<br><font size=2 face="sans-serif">I will be in touch shortly.</font>
<br>
<br><font size=2 face="sans-serif">Regards,</font>
<br><font size=2 face="sans-serif">Trent</font>
<br>
<br><font size=2 face="sans-serif">----------</font>
<br><font size=2 color=blue face="sans-serif">Comments</font>
<br><font size=2 face="sans-serif"><i>i have a patch for gdal 1.7.3 to
improve isis2 driver.</i></font>
<br><font size=2 face="sans-serif"><i>* writing functionality for QUBE
object </i></font><font size=2 color=blue face="sans-serif"><i>-</i>
again I would like to see an attempt at supporting projections also - I
will help.</font>
<br><font size=2 face="sans-serif"><i>* grab null value </i></font><font size=2 color=blue face="sans-serif">-
What does this mean as support for a single NULL value was there? Does
this address the fact that all ISIS2, PDS, and ISIS3 can support multiple
NULL values? </font>
<br><font size=2 face="sans-serif"><i>* improve the type reading </i></font><font size=2 color=blue face="sans-serif">-
great</font>
<br><font size=2 face="sans-serif"><i>* can read qube with back plane,
side plane and bottom plane </i></font><font size=2 color=blue face="sans-serif">-
great again sI will need to see how you supported side/bottom planes. Do
you make a new file? </font>
<br><font size=2 face="sans-serif"><i>* can read a file with label detached
or attached. -</i></font><font size=2 color=blue face="sans-serif"> I thought
this was already implemented? Maybe there were some fixes though.</font><font size=2 face="sans-serif"><i>
</i></font>
<br>
<br><font size=2 face="sans-serif">----------</font>
<br>
<br><font size=2 face="sans-serif">New PDS bug which I could use help with
-- I have recently seen a new label from the LOLA team that allows one
label to point to two different image types. This breaks the simple GDAL
parser. </font>
<br>
<br><font size=2 face="sans-serif">In these LOLA labels there is a new
section which<b> wraps</b> the file description.</font>
<br><tt><font size=2>OBJECT
= UNCOMPRESSED_FILE</font></tt>
<br><tt><font size=2>...</font></tt>
<br><tt><font size=2>END_OBJECT
= UNCOMPRESSED_FILE</font></tt>
<br><font size=2 face="sans-serif">from: </font><a href=http://imbrium.mit.edu/DATA/LOLA_GDR/CYLINDRICAL/IMG/LDEC_16.LBL><font size=2 face="sans-serif">http://imbrium.mit.edu/DATA/LOLA_GDR/CYLINDRICAL/IMG/LDEC_16.LBL</font></a>
<br>
<br><font size=2 face="sans-serif">and then for a compressed file. I know
the PDS reader doesn't support JP2s but it would be nice (or at least report
an appropriate warning):</font>
<br><font size=2 face="Courier New">OBJECT
= COMPRESSED_FILE</font>
<br><font size=2 face="Courier New"> FILE_NAME
= "LDEC_16.JP2"</font>
<br><font size=2 face="Courier New"> RECORD_TYPE
= UNDEFINED</font>
<br><font size=2 face="Courier New"> FILE_RECORDS
= UNK</font>
<br><font size=2 face="Courier New"> ENCODING_TYPE
= "JP2"</font>
<br><font size=2 face="Courier New"> INTERCHANGE_FORMAT
= BINARY</font>
<br><font size=2 face="Courier New"> UNCOMPRESSED_FILE_NAME =
"LDEC_16.IMG"</font>
<br><font size=2 face="Courier New"> REQUIRED_STORAGE_BYTES =
"14831085"</font>
<br><font size=2 face="Courier New"> ^DESCRIPTION
= "JP2INFO.TXT"</font>
<br><font size=2 face="Courier New">END_OBJECT
= COMPRESSED_FILE</font>
<br><a href=http://imbrium.mit.edu/DATA/LOLA_GDR/CYLINDRICAL/JP2/LDEC_16_JP2.LBL><font size=2 face="sans-serif">http://imbrium.mit.edu/DATA/LOLA_GDR/CYLINDRICAL/JP2/LDEC_16_JP2.LBL</font></a>
<br>
<br><font size=2 face="sans-serif">Unfortunately I have seen these two
sections in the <b>same</b> label! I'm not sure how to handle that. I guess
just pick up the first one that works. And again, it will only be the "UNCOMPRESSED_FILE"
section for now.</font>
<br>
<br>
<br>
<br>
<br>
<br>
<table width=100%>
<tr valign=top>
<td><font size=1 color=#5f5f5f face="sans-serif">From:</font>
<td><font size=1 face="sans-serif">Ludovic Mercier <ludovic.mercier@gmail.com></font>
<tr valign=top>
<td><font size=1 color=#5f5f5f face="sans-serif">To:</font>
<td><font size=1 face="sans-serif">gdal-dev@lists.osgeo.org</font>
<tr>
<td valign=top><font size=1 color=#5f5f5f face="sans-serif">Cc:</font>
<td><font size=1 face="sans-serif">thare@usgs.gov, rsoricone@usgs.gov</font>
<tr valign=top>
<td><font size=1 color=#5f5f5f face="sans-serif">Date:</font>
<td><font size=1 face="sans-serif">12/06/2010 09:02 AM</font>
<tr valign=top>
<td><font size=1 color=#5f5f5f face="sans-serif">Subject:</font>
<td><font size=1 face="sans-serif">patch for ISIS2 driver</font></table>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>Hi,<br>
<br>
i have a patch for gdal 1.7.3 to improve isis2 driver.<br>
The patch had<br>
* writing functionality for QUBE object<br>
* grab null value<br>
* improve the type reading<br>
* can read qube with back plane, side plane and bottom plane<br>
* can read a file with label detached or attached.<br>
<br>
and i have modify nasakeyword handler to reduce sensibility of parser to
<br>
little error on comment. (Like if we have char after end comment.)<br>
<br>
but i have rewrite/move a lot of lines... I use this patch for a <br>
research project from one year ago. I work on hyperspectral data with <br>
OTB library.<br>
<br>
I think is it possible to easily merge pdsdataset.cpp and isis2dataset.cpp<br>
pdsdataset work on IMAGE tag and isis2 on QUBE tag but it is the same <br>
workflow for all object (QUBE, IMAGE or SPECTRAL_QUBE)<br>
<br>
Warning for writing no geographical information are writing now, and <br>
create_copy is not implemented.<br>
<br>
Ludovic.<br>
<br>
[attachment "gdal-1.7.3-lpg-613.patch" deleted by Trent M Hare/GD/USGS/DOI]
</font></tt>
<br>
<br>