<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 11/30/2011 10:20 PM, Even Rouault wrote:
<blockquote
cite="mid:201111302120.46446.even.rouault@mines-paris.org"
type="cite">
<meta name="qrichtext" content="1">
<style type="text/css">
p, li { white-space: pre-wrap; }
</style>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">Hi SWIG binding users/devs,</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">Any opinion on
<a class="moz-txt-link-freetext" href="http://trac.osgeo.org/gdal/ticket/4360">http://trac.osgeo.org/gdal/ticket/4360</a> ?</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">"""After the changes done in <a
moz-do-not-send="true"
href="http://trac.osgeo.org/gdal/changeset/11529"><span
style=" text-decoration: underline; color:#0057ae;">http://trac.osgeo.org/gdal/changeset/11529</span></a>
/ <a moz-do-not-send="true"
href="http://trac.osgeo.org/gdal/ticket/1635"><span style="
text-decoration: underline; color:#0057ae;">http://trac.osgeo.org/gdal/ticket/1635</span></a>
, any CE_Failure error emitted by CPLError() in the Open()
method of GDAL and OGR drivers, and not cleared, will cause the
swig bindings to return a null dataset, even if the driver
returned a valid one. </p>
<p style=" margin-top:12px; margin-bottom:12px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">Sometimes those errors are not critical, and
users regularly complain (last occurrence is <a
moz-do-not-send="true"
href="http://lists.osgeo.org/pipermail/gdal-dev/2011-November/030960.html"><span
style=" text-decoration: underline; color:#0057ae;"> http://lists.osgeo.org/pipermail/gdal-dev/2011-November/030960.html</span></a>
) that they can open them successfully with C/C++ API, but not
from Java/Python/etc, so I'd suggest the following patch that
adds a bIgnoreErrors option, that if turned on will reset the
error flag in the case discussed here. By default, the new
option is not turned on. """</p>
</blockquote>
<br>
GDAL has warnings, failures and fatal errors. I don't know the
semantical error between a failure and a fatal error and they are
treated the same in the bindings. Also at least in Perl there are
only tools for warnings and (fatal) errors. Is this a case of a
failure but not a fatal error and the sign is that the returned
value is ok but there is a failure state. Maybe we should convert
the failure into a warning in such a case? I guess that would be my
suggestion.<br>
<br>
I usually think about these from the point of view of somebody using
a GUI and I don't see a checkbox in open vector dataset dialog box
for "ignore errors".<br>
<br>
I'm concerned about the viability of the returned dataset object -
it is ok if the user is warned and given a not perfect object, but
it is not ok to return an object, which may lead to core dumps or
other bad things.<br>
<br>
Ari<br>
<br>
<blockquote
cite="mid:201111302120.46446.even.rouault@mines-paris.org"
type="cite">
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">Best regards,</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">Even</p>
</blockquote>
<br>
</body>
</html>