<div dir="ltr">Please fork the 80 col style guide to a new thread. Yes, there are lots of issues with the coding style, but can we do one thing at a time? If you are really motivated, why not write a proposal like mine and talk through the issues of different column constraints (there are good reasons for the many different ways and related issues). Then start a new thread with it.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 9, 2016 at 9:43 AM, Joaquim Luis <span dir="ltr"><<a href="mailto:jluis@ualg.pt" target="_blank">jluis@ualg.pt</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I like one statement per line because it helps walking through the code with gdb; you can see the whole statement that is going to be executed.<br>
</blockquote>
<br></span>
Fully agree, and my example respects that.<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I also share the idea that seeing a whole subroutine or a logical part at once helps understanding the code.<br>
<br>
Ari<br>
<br>
09.05.2016, 18:14, Joaquim Luis kirjoitti:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
There is one aspect of the coding style that I honestly do not understand. Why continuing to recommend the 80 chars line width? I don't by the readability argument, well on the contrary, if because of it the result is an excess 'verticalization' of the code it becomes much harder to read.<br>
<br>
I don't know for you guys but when I'm forced to permanently scroll up and down it becomes really much harder to study a code. For me the ideal is that a function holds in a single screen size, but ofc without piling up everything to reach that goal.<br>
<br>
A little example from gdaldem_lib.cpp (line 240)<br>
<br>
****************** Current code *********************************<br>
<br>
for ( i = 0; i < 2 && i < nYSize; i++)<br>
{<br>
if( GDALRasterIO( hSrcBand,<br>
GF_Read,<br>
0, i,<br>
nXSize, 1,<br>
pafThreeLineWin + i * nXSize,<br>
nXSize, 1,<br>
GDT_Float32,<br>
0, 0) != CE_None )<br>
{<br>
eErr = CE_Failure;<br>
goto end;<br>
}<br>
}<br>
****************************************************************************** <br>
************ What I think would be reasonable ********************************<br>
<br>
for (i = 0; i < 2 && i < nYSize; i++) {<br>
if (GDALRasterIO(hSrcBand, GF_Read, 0, i, nXSize, 1, pafThreeLineWin + i * nXSize, nXSize, 1,<br>
GDT_Float32, 0, 0) != CE_None ) {<br>
eErr = CE_Failure;<br>
goto end;<br>
}<br>
}<br>
****************************************************************************** 7 lines instead of 15, and is it less readable (in a text editor, not in a mail client)?<br>
<br>
Joaquim<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 9 May 2016 at 09:15, Ari Jolma <<a href="mailto:ari.jolma@gmail.com" target="_blank">ari.jolma@gmail.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
05.05.2016, 01:30, Kurt Schwehr kirjoitti:<br>
<br>
Hi all,<br>
<br>
If you've been watching the timeline on trac, you have probably seen a large<br>
number of cleanup CLs from me. It's definitely past time to get some<br>
discussion going on these changes. If the community likes these, we can add<br>
them to rfc8_devguide.<br>
<br>
<br>
It is very minimal right now. Good style guides tend to be quite large,<br>
e.g., <a href="https://google.github.io/styleguide/cppguide.html" rel="noreferrer" target="_blank">https://google.github.io/styleguide/cppguide.html</a> or<br>
<a href="http://geosoft.no/development/cppstyle.html" rel="noreferrer" target="_blank">http://geosoft.no/development/cppstyle.html</a><br>
</blockquote>
<br>
Good C++ guidelines that fit on a single page is all you need<br>
these days, after Bjarne Stroustrup<br>
<a href="https://parasol.tamu.edu/people/bs/622-GP/C++11-style.pdf" rel="noreferrer" target="_blank">https://parasol.tamu.edu/people/bs/622-GP/C++11-style.pdf</a><br>
<br>
Best regards,<br>
</blockquote>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</blockquote>
<br>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</blockquote>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">--<div><a href="http://schwehr.org" target="_blank">http://schwehr.org</a></div></div>
</div>