<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Kurt.</p>
<p>The md5.cpp and md5.h were in frmst/wms driver folder. As I see
from header this files are not initially from GDAL project.</p>
<p>I moved this files to port with minimum changes - only macros for
suppress Doxygen parsing.</p>
<p>The motivation of this moving was:</p>
<p>1. md5 functions used in several drivers (WMS and WFS) and may be
others in future.<br>
</p>
<p>2. need API function to get the same md5 hash as used in WMS for
autotesting functionality.</p>
<p>3. downloading area of interest into the WMS file based cache by
external programs. May be some other utilization. <span
style="color: rgb(119, 119, 119); font-family: arial,
sans-serif; font-size: 13px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: nowrap; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;"><span></span></span></p>
<p>I think ideally the OpenSSL MD5 functions must be using. But this
will be one more dependency. Do we need it?<br>
</p>
<p><br>
</p>
<pre class="moz-signature" cols="72">Best regards,
Dmitry</pre>
<div class="moz-cite-prefix">20.12.2017 16:43, Kurt Schwehr пишет:<br>
</div>
<blockquote type="cite"
cite="mid:CACmBxyuvNoSeX2u-11F2LPWa28xpVeQGZMa9e6FD=8vGk0UJbQ@mail.gmail.com">
<pre wrap="">Hi all,
Can we discuss cvs_MD5* from <a class="moz-txt-link-freetext" href="https://trac.osgeo.org/gdal/changeset/41086">https://trac.osgeo.org/gdal/changeset/41086</a> ?
I very much appreciate the work that bishop is doing and I hate to slow
down a contributor
I am really worried about code like this going into GDAL, especially into
port/
But my worries are:
- this in no way conforms to other code in GDAL
- has the potential to collide with other code that imports this code
- it has a very awkward C style
- the commit message did not point to where it came from (at least it's not
hard to guess)
- the file naming is different than (most) of the rest of the directory
- and...
Yes, we have other libraries included, but it seems like a road we don't
want to go down
-kurt
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
gdal-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a></pre>
</blockquote>
<br>
</body>
</html>