<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Ari,</p>
<p>The pull request and discussion can be found here:
<a class="moz-txt-link-freetext" href="https://github.com/OSGeo/gdal/pull/280">https://github.com/OSGeo/gdal/pull/280</a></p>
<p>I cannot imagine that this improvements will affect something
else. MD5 used for cache paths initially, I only added some
improvements for WMS cache size limits, expire time and split
cache per dataset base (i.e. to delete cached files when dataset
deletes).<br>
</p>
<p>What about your idea about common caching classes/functions -
this is topic to discuss. <br>
</p>
<pre class="moz-signature" cols="72">Best regards,
Dmitry</pre>
<div class="moz-cite-prefix">21.12.2017 0:32, Ari Jolma пишет:<br>
</div>
<blockquote type="cite"
cite="mid:aef867d1-d307-ce8f-32c8-1722698fa9cb@gmail.com">My
comments on this:
<br>
<br>
1) The MD5 function seems to be needed only(?) for the WMS cache
and probably also WFS. To me that highlights the need for some
integration work regarding caching in GDAL. I also implemented yet
another caching code for the WCS (without MD5). Looking at my
$HOME/.gdal I see also gmlas_xsd_cache and srs_cache.
<br>
<br>
2) This discussion thread also highlights the need to go towards
more pull request style development at least for bigger changes.
<br>
<br>
Ari
<br>
<br>
<br>
Kurt Schwehr kirjoitti 21.12.2017 klo 02:56:
<br>
<blockquote type="cite">Dmitry,
<br>
<br>
Statements like this indicate a world of trouble:
<br>
<br>
> I'm not sure that Python produce the same hash than
cvs_MD5*.
<br>
> Also I'm not sure what in future they will be the same.
<br>
<br>
If you remove the swig and python stuff, move the CPLMD5String
to cpl_md5.{cpp,h}, and follow Even's suggestions, I will be
much happier with the change. A C++ test would be good too.
I'll be happy to do a quick fix up of a few things that I see in
the md5 code once it is to that point. I do think it is a good
thing that there be md5 support in port along with the existing
sha{1,256} code.
<br>
<br>
I see what you are saying about
the OGRGeometry::exportTo{json,kml,gml}, but that doesn't (to
me) support your argument. My personal opinion is that GDAL
would have been stronger if those had separate and not been a
part of OGRGeometry.
<br>
<br>
If there is a critical difference between CPLMD5String or a
language and use case where md5 support in that language from
GDAL is really required, you need to first document that issue.
<br>
<br>
On Wed, Dec 20, 2017 at 7:46 AM, Dmitry Baryshnikov
<<a class="moz-txt-link-abbreviated" href="mailto:bishop.dev@gmail.com">bishop.dev@gmail.com</a> <a class="moz-txt-link-rfc2396E" href="mailto:bishop.dev@gmail.com"><mailto:bishop.dev@gmail.com></a>>
wrote:
<br>
<br>
Just the note that CPLMD5String not only for Python, but any
other
<br>
API clients: C/C++, Java, Perl, etc.
<br>
<br>
But, I agree, it can be easily removed.
<br>
<br>
Best regards,
<br>
Dmitry
<br>
<br>
20.12.2017 18 <a class="moz-txt-link-rfc2396E" href="tel:20.12.2017%2018"><tel:20.12.2017%2018></a>:35, Even Rouault
пишет:
<br>
<br>
And why are you exposing this to python? Python
has
<br>
md5 hashing
<br>
<br>
already
<br>
<br>
built in.
<br>
<br>
I'm not sure that Python produce the same hash than
cvs_MD5*.
<br>
<br>
I do hope they return the same thing. MD5 is a
standardized
<br>
algorithm:
<br>
<a class="moz-txt-link-freetext" href="https://tools.ietf.org/html/rfc1321">https://tools.ietf.org/html/rfc1321</a>
<br>
<a class="moz-txt-link-rfc2396E" href="https://tools.ietf.org/html/rfc1321"><https://tools.ietf.org/html/rfc1321></a>
<br>
<br>
I'm not sure we really need to expose it our CPL MD5
through
<br>
Python.
<br>
<br>
<br>
_______________________________________________
<br>
gdal-dev mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>
<a class="moz-txt-link-rfc2396E" href="mailto:gdal-dev@lists.osgeo.org"><mailto:gdal-dev@lists.osgeo.org></a>
<br>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a>
<br>
<a class="moz-txt-link-rfc2396E" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev"><https://lists.osgeo.org/mailman/listinfo/gdal-dev></a>
<br>
<br>
<br>
<br>
<br>
-- <br>
-- <br>
<a class="moz-txt-link-freetext" href="http://schwehr.org">http://schwehr.org</a>
<br>
<br>
<br>
_______________________________________________
<br>
gdal-dev mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>
<br>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a>
<br>
</blockquote>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
gdal-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a></pre>
</blockquote>
<br>
</body>
</html>