<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi,</p>
<p>PyTest is a great test-suite.</p>
<p>If I may make one suggestion as someone who has used it for a
while - it's worth spending a little thought on coming up with a
scheme for test-ids. Especially if you're going to use
parameterisation.</p>
<p>Otherwise PyTest comes up with names that may be accurate
(they're a concatenation of the parameters), but are relatively
meaningless. For example "gdaladdo--100", "gdaladdo-foo", etc, as
compared to more useful ids like "gdaladdo-too-low-input",
"gdaladdo-bad-string-input" which tell you immediately what the
test is actually meant to be testing.</p>
<p>There's a hook called pytest_make_parametrize_id which allows you
to create your own ids (I find the built-in methods of id
generation either cumbersome, or bit-rot prone).</p>
<p>I'm suggesting it now because it's more helpful if you do it from
the start.</p>
<p>Cheers,</p>
<p>Jonathan<br>
</p>
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 2018-12-05 22:40, Craig de Stigter
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF1M8pegMEBkY0cOVYPAUGfA0+kVQZ_cGrz06ainZAVA532gMw@mail.gmail.com">
<div dir="ltr">
<div>Hi</div>
<div><br>
</div>
<div>I appreciate your comments on the pytest proposal and all
the support to help get it this far. Given no actionable
improvements have been suggested, and the feedback thus far
seems encouraging...</div>
<div><br>
</div>
<div>I move to adopt RFC 72: Run tests with pytest.<br>
</div>
<div><br>
</div>
<div><a href="https://trac.osgeo.org/gdal/wiki/rfc72_pytest"
moz-do-not-send="true">https://trac.osgeo.org/gdal/wiki/rfc72_pytest</a></div>
<div><br>
</div>
<div><br>
</div>
Cheers
<div>Craig de Stigter<br>
</div>
</div>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
gdal-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a></pre>
</blockquote>
<br>
</body>
</html>