<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"Segoe UI";
panose-1:2 11 5 2 4 2 4 2 2 3;}
@font-face
{font-family:"Segoe UI \,sans-serif";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin-top:0in;
margin-right:0in;
margin-bottom:8.0pt;
margin-left:0in;
line-height:105%;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:70.85pt 70.85pt 56.7pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi Even,<o:p></o:p></span></p>
<p><span lang="EN-US">Thank you for your prompt reply.<br>
<br>
</span><span lang="EN-US">> “I assume the driver would depend on the ODBC library, and would require users to build
</span><a href="https://github.com/SAP/odbc-cpp-wrapper"><span lang="EN-US">https://github.com/SAP/odbc-cpp-wrapper</span></a><span lang="EN-US"> as the corresponding ODBC driver ?”<o:p></o:p></span></p>
<p><span lang="EN-US">The odbc-cpp-wrapper library is going to be used only during the compilation phase and linked statically, thus end users will get only one dynamic/shared library of the HANA driver. Hence, no additional actions are required from end users.
For those who want to compile the GDAL sources with HANA support on their own, the sources of the odbc-cpp-wrapper are needed. However, this step can be omitted if we store a copy of the library in
</span><a href="https://github.com/OSGeo/gdal/tree/master/gdal/third_party"><span lang="EN-US">https://github.com/OSGeo/gdal/tree/master/gdal/third_party</span></a><span lang="EN-US"> like we did in QGIS (see
</span><a href="https://github.com/qgis/QGIS/tree/master/external/odbccpp"><span lang="EN-US">https://github.com/qgis/QGIS/tree/master/external/odbccpp</span></a><span lang="EN-US">).
</span><span lang="EN-US" style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p></o:p></span></p>
<p><span lang="EN-US">Note, that any HANA plugin (GDAL/QGIS) also requires the SAP HANA Client (https://tools.hana.ondemand.com/#hanatools) to be able to connect an SAP HANA database.<br>
</span><span lang="EN-US"><br>
> “Below a non-exhaustive lists of points that should be covered IMHO. A number of them are open questions where input from the community is welcome.<br>
- criteria for acceptance:<br>
* (obvious) source code contributed to the repository should follow its licensing terms”<br>
<br>
</span><span lang="EN-US" style="font-size:10.5pt;font-family:"Segoe UI",sans-serif">The license will be X/MIT.<o:p></o:p></span></p>
<p><span lang="EN-US">> “* is the driver of sufficient general interest ? For example, we'd likely don't want to accept drivers for a in-house file format of a company/organization that isn't distributed outside it.”<o:p></o:p></span></p>
<p><span lang="EN-US">This is not the case for the HANA driver. </span><span lang="EN-US" style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:0in;line-height:normal"><span lang="EN-US">> “* should we require CI tests ? Some tests, especially ones relying on external services, can be flaky.”<br>
<br>
<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:0in;line-height:normal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;mso-fareast-language:DE">We can consider adding CI tests either using a HANA instance in the cloud or in a docker
container.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><br>
> “- each (at least, new) driver should have at least one name in front of it in the list in https://github.com/OSGeo/gdal/wiki/Maintainers-per-sub-system . What should we expect from the maintainer: monitoring of the mailing list and issue tracker (at least
bi weekly ?), some form of handling of it (making sure the issue is well described, and some time frame to address it when relevant), reviewing pull requests in their "area of responsibility" (... and outside it. For example, I see a number of QGIS developers
having reviewed your pull requests, but did you help reviewing their pull requests. I don't mean to pinpoint on anybody in particular, as it is a general pattern in most GDAL driver contributions too), participation to general / cross-driver maintenance tasks,
...”<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:0in;line-height:normal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;mso-fareast-language:DE">There will be a contact person at SAP responsible for the maintenance.<br>
<br>
</span><span lang="EN-US">> “- if someone refactors GDAL internals, who is responsible for adjusting the various drivers to build and work properly ? Open question honestly, and from my experience, this ………………….”<br>
<br>
</span><span lang="EN-US" style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;mso-fareast-language:DE"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:0in;line-height:normal"><span lang="EN-US" style="mso-fareast-language:DE">Unfortunately, we are not able to answer the remaining raised points</span><span lang="EN-US" style="font-size:10.5pt;font-family:"Segoe UI",sans-serif">
</span><span lang="EN-US" style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;mso-fareast-language:DE">as they are beyond our expertise</span><span lang="EN-US" style="mso-fareast-language:DE">.<br>
Perhaps they should be addressed in a separate dedicated discussion.</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><br>
</span><span lang="EN-US" style="font-size:10.5pt;line-height:105%;font-family:"Segoe UI ,sans-serif",serif">Kind regards,</span><span lang="EN-US"><br>
</span><span lang="EN-US" style="font-size:10.5pt;line-height:105%;font-family:"Segoe UI ,sans-serif",serif">Maxim Rylov on behalf of the HANA Spatial Team</span><span lang="EN-US"><o:p></o:p></span></p>
</div>
</body>
</html>