<div dir="ltr"><div>Even,</div><div><br></div><div>Argh, I typed "unsigned char" when I meant "signed". Changing GDT_Byte to *signed char* is too big of a change,
I guess?</div><div dir="ltr"><br></div><div>I like the plan for PIXELTYPE.</div><div><br></div><div>Sorry about the noise, everybody!<br></div><div><br></div><div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Nov 8, 2022 at 5:04 PM Even Rouault <<a href="mailto:even.rouault@spatialys.com">even.rouault@spatialys.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
Sean,<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div>Changing GDT_Byte to unsigned char is too big of a change,
I guess? I can work with that.</div>
</div>
</blockquote>
GDT_Byte semantic is already unsigned char / uint8. What did you
mean?<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div>Is there any advantage to a GDT_UInt8 type that can't be
changed by a PIXELTYPE option?</div>
</div>
</blockquote>
<p>That would be super confusing if we had both GDT_Byte and
GDT_UInt8 and they are not just simple aliases.<br>
</p>
<p>The PIXELTYPE option should die. The RFC proposes to make it die
on the reading side (as a metadata item).</p>
<p>We could also make it die on the writing side as a creation
option, but I didn't dare to do it right now and just propose this
is considered a legacy deprecated way. Would certainly be
something worth doing for a GDAL 4.0 if such thing ever happened.<br>
</p>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Nov 8, 2022 at
12:39 PM Even Rouault <<a href="mailto:notifications@github.com" target="_blank">notifications@github.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<blockquote>
<p dir="auto">Ubyte (same as uint8) vs byte?</p>
</blockquote>
<p dir="auto">what do you suggest exactly: keep GDT_Byte
in the enumeration and add <code>#define GDT_UByte GDT_Byte</code>
to create the alias ?</p>
<p style="font-size:small;color:rgb(102,102,102)">—<br>
Reply to this email directly, <a href="https://github.com/OSGeo/gdal/pull/6633#issuecomment-1307736762" target="_blank">view it on
GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAAIHIKG7X65SX4OULJMUFTWHKT5TANCNFSM6AAAAAAR2E6MJY" target="_blank">unsubscribe</a>.<br>
You are receiving this because you commented.<img src="https://github.com/notifications/beacon/AAAIHIJG56BVVT5CI6VEP7TWHKT5TA5CNFSM6AAAAAAR2E6MJ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSN6J5LU.gif" alt="" width="1" height="1"><span style="color:transparent;font-size:0px;display:none;overflow:hidden;opacity:0;width:0px;height:0px;max-width:0px;max-height:0px">Message
ID: <span><OSGeo/gdal/pull/6633/c1307736762</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</blockquote>
</div>
<br clear="all">
<br>
-- <br>
<div dir="ltr">Sean Gillies</div>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
gdal-dev mailing list
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a>
</pre>
</blockquote>
<pre cols="72">--
<a href="http://www.spatialys.com" target="_blank">http://www.spatialys.com</a>
My software is free, but my time generally not.</pre>
</div>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature">Sean Gillies</div></div></div>